-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diff operation fails #164
Comments
On Linux it also fails.
OS: Linux Mint 17.2 Rafaela (based on Ubuntu 14.04.2 LTS) |
@jegra Have you try config diff command of full path? |
Yes, it exists: $ /usr/bin/diff --version
diff (GNU diffutils) 3.3
Copyright © 2013 Free Software Foundation, Inc. |
Also fails on OS X and /usr/bin/diff does exist. |
For Windows it seems to add a double-quote before the command which breaks it. Remote Sync Settings > Diff tool command The problem there being that the diff tool command gets wrapped with double-quotes Changing the Diff tool command to |
For mac also it seems double-quote breaks it. |
Removing the double quotes for me didn't fix it however... |
I have the same problem on MacOS too ... Anyone managed to get it fixed? |
I managed to get around the error. The problem is the "return if not err" below the exec. I changed the line to: return if err.code==1 || err.code==0 but then simply nothing happends ... so there is no code that do something with the result of the diff result :-( ... |
I ran into this issue as well, and it appears to be a documentation problem. The diff option is designed to launch a diff "tool", i.e. a graphical program that helps visualize and review diffs (which typically does not return a nonzero exit code)
On Mac, diff tools include It would be helpful if the remote-sync documentation explicitly mentioned that it expects a graphical program, not a path to the diff executable. |
See my diff tool command explanation #375 |
This might help Mac users. I used these instructions for p4merge.app |
On Windows 8, using 'diff' for difftoolCommand value, diff operation fails. Note that when pasting the exact command that is output to the Atom console into a command prompt, it works as expected. In other words, this works from the command line:
diff C:\Users\Joe\path\to\file.php C:\Users\Joe\AppData\Local\Temp\remote-sync\path\to\file.php
...but fails from within Atom. The full error report from the console:
The text was updated successfully, but these errors were encountered: