Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove override of createJSModules #12

Open
Kuchitama opened this issue Dec 8, 2017 · 0 comments
Open

Remove override of createJSModules #12

Kuchitama opened this issue Dec 8, 2017 · 0 comments

Comments

@Kuchitama
Copy link

React Native 0.47 has removed the createJSModules method in ReactPackage. Therefore any overrides of this method will need to be removed from the library, or this will cause a compilation error.

See: facebook/react-native@ce6fb33

This is helpful: https://github.com/oblador/react-native-vector-icons/pull/516/files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Kuchitama