-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Psalm level 2 #246
Psalm level 2 #246
Conversation
vjik
commented
Jan 21, 2024
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ❌ |
Breaks BC? | ✔️ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #246 +/- ##
============================================
+ Coverage 76.21% 76.25% +0.03%
+ Complexity 586 585 -1
============================================
Files 48 48
Lines 2031 2030 -1
============================================
Hits 1548 1548
+ Misses 483 482 -1 ☔ View full report in Codecov by Sentry. |
@@ -49,7 +50,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int | |||
if ($input->hasOption('groups') && $input->getOption('groups')) { | |||
$build = $this->getConfigBuild($config); | |||
$groups = array_keys($build); | |||
ksort($groups); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not need. array_keys returns already sorted array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ksort is sorted by keys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe here need to use sort instead ksort?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ksort is sorted by keys
What?
There should be a sorted list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh gotcha. You're right, there should be sort
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added sort
.
@@ -62,7 +61,6 @@ | |||
LoggerInterface::class => [LoggerInterfaceProxy::class, LogCollector::class], | |||
EventDispatcherInterface::class => [EventDispatcherInterfaceProxy::class, EventCollector::class], | |||
ClientInterface::class => [HttpClientInterfaceProxy::class, HttpClientCollector::class], | |||
CacheInterface::class, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems, code don't work with integer keys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CacheInterface should be also proxied. Could you add it then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, proxy and collector for CacheInterface
not exist.