Support Spotify #68
Closed
Support Spotify #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
save bilibili_history with json
yihong0618
reviewed
Oct 8, 2022
Comment on lines
+60
to
+67
| def _parse_spotify_history(self): | ||
| if os.path.exists(self.spotify_file): | ||
| with open(self.spotify_file, "r") as f: | ||
| self.number_by_date_dict = json.load(f) | ||
|
|
||
| def _writeback_spotify_history(self): | ||
| with open(self.spotify_file, "w") as f: | ||
| json.dump(self.number_by_date_dict, f, sort_keys=True) |
There was a problem hiding this comment.
This two functions seems same as bilibili can we refactor them to one?
There was a problem hiding this comment.
Maybe I can put it in BaseLoader. When needed in SpotifyLoader, use self._type to get the name of history file. If other loader needs the function to save history data, call it in the same way.
| dest="spotify_client_id", | ||
| type=str, | ||
| required=optional, | ||
| help="", |
Comment on lines
+70
to
+79
| now = datetime.datetime.now() | ||
| yesterday = now - datetime.timedelta( | ||
| 1, | ||
| hours=now.hour, | ||
| minutes=now.minute, | ||
| seconds=now.second, | ||
| microseconds=now.microsecond, | ||
| ) | ||
| last_yesterday = yesterday + datetime.timedelta( | ||
| hours=23, minutes=59, seconds=59 |
Comment on lines
+133
to
+135
| if before >= after: | ||
| return self.get_api_data(next_url, after, limit, data_list) | ||
| return data_list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #67