Skip to content

Commit

Permalink
Magic constants are replaced by blob.size (Resolves #2634)
Browse files Browse the repository at this point in the history
* Removes magic constants
  • Loading branch information
kritisingh1 authored and inexorabletash committed Mar 1, 2018
1 parent c71d9ca commit bb60bf3
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions FileAPI/blob/Blob-slice-overflow.html
Original file line number Diff line number Diff line change
Expand Up @@ -16,26 +16,26 @@

test(function() {
var blob = new Blob([text]);
var sliceBlob = blob.slice(-1, 2000);
assert_equals(sliceBlob.size, 2000-(2000-1), "Bolb slice size");
var sliceBlob = blob.slice(-1, blob.size);
assert_equals(sliceBlob.size, 1, "Blob slice size");
}, "slice start is negative, relativeStart will be max((size + start), 0)");

test(function() {
var blob = new Blob([text]);
var sliceBlob = blob.slice(2001, 2000);
assert_equals(sliceBlob.size, 0, "Bolb slice size");
var sliceBlob = blob.slice(blob.size + 1, blob.size);
assert_equals(sliceBlob.size, 0, "Blob slice size");
}, "slice start is greater than blob size, relativeStart will be min(start, size)");

test(function() {
var blob = new Blob([text]);
var sliceBlob = blob.slice(1998, -1);
assert_equals(sliceBlob.size, (2000-1)-1998, "Bolb slice size");
var sliceBlob = blob.slice(blob.size - 2, -1);
assert_equals(sliceBlob.size, 1, "Blob slice size");
}, "slice end is negative, relativeEnd will be max((size + end), 0)");

test(function() {
var blob = new Blob([text]);
var sliceBlob = blob.slice(1998, 2999);
assert_equals(sliceBlob.size, 2000-1998, "Bolb slice size");
var sliceBlob = blob.slice(blob.size - 2, blob.size + 999);
assert_equals(sliceBlob.size, 2, "Blob slice size");
}, "slice end is greater than blob size, relativeEnd will be min(end, size)");

</script>
Expand Down

0 comments on commit bb60bf3

Please sign in to comment.