Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper support for WiX 5 #1163

Open
Vort opened this issue Aug 14, 2024 · 2 comments
Open

Proper support for WiX 5 #1163

Vort opened this issue Aug 14, 2024 · 2 comments
Labels
help wanted Input from contributors wanted windows Operating system-specific

Comments

@Vort
Copy link

Vort commented Aug 14, 2024

build-msi.sh script first installs WiX 5:

dotnet tool install --global wix --version 5.0.0

Then executes candle and light:
candle $CANDLEFLAGS -out ${PKGNAME}-${PKGVERSION}-${PKGARCH}.wixobj -arch ${PKGARCH} wix.xml && \
light $LIGHTFLAGS -ext WixUtilExtension.dll -out ${PKGNAME}-${PKGVERSION}-${PKGARCH}.msi ${PKGNAME}-${PKGVERSION}-${PKGARCH}.wixobj

The problem is WiX 5 have no candle and light!
They were removed in version 4:
https://wixtoolset.org/docs/fourthree/

What happens here I suppose is that GitHub Actions contain WiX 3 and it is used despite WiX 5 being installed.
I think it is better to port script for correct usage of WiX 5 instead.

@neilalexander
Copy link
Member

Fancy volunteering a PR?

@Vort
Copy link
Author

Vort commented Aug 15, 2024

I have almost no knowledge about GitHub Actions and WiX.
So to make decent PR I need to learn these technologies.
Maybe I will do it, but not now.

@neilalexander neilalexander added help wanted Input from contributors wanted windows Operating system-specific labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Input from contributors wanted windows Operating system-specific
Projects
None yet
Development

No branches or pull requests

2 participants