-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: clear key mapping; default to <C-l> #739
base: main
Are you sure you want to change the base?
Conversation
Uses Config.windows.ask.start_insert to determine whether to go insert mode after clearing
@yetone have my back with the linter please |
Should we confirm before clearing? Because in my opinion, deletion is always the most dangerous operation. |
TipCopilotChat.nvim behaves the same way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually don't agree with this. This should be done manually instead of this.
delete is dangerous, share same sentiment with yetone (but it seems like you are saving it to history before deleting it, which seems a bit misleading)
I'm fine doing this through a cmd or sth
How about double
how weird - I'll take a look |
L1245 |
Right, I just replicated the same behavior of avante.nvim/lua/avante/sidebar.lua Lines 1199 to 1208 in a8e2b9a
You might wanna look at the blame history. |
Added double keystroke for This behavior lines up with my expectation, but if you don't vision it merged feel free to leave it aside or modify it at will |
…ing chat history fix(lua/avante/sidebar.lua): improve handling of warning shown flag to prevent accidental clearing of chat history
Uses
Config.windows.ask.start_insert
to determine whether to go insert mode after clearing. Is this something we want, or should we create a separate config?Clear mapping is set on
mappings.sidebar.clear
, but feel free to suggest a better one if this doesn't fit the sidebar context