Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic opt-out is stored permanently #39

Open
gibson042 opened this issue Mar 14, 2016 · 1 comment
Open

Automatic opt-out is stored permanently #39

gibson042 opened this issue Mar 14, 2016 · 1 comment
Labels
enhancement help wanted

Comments

@gibson042
Copy link

When the askPermission prompt goes unanswered for too long, a negative answer is implied so processing can continue. But that result is treated identically to an explicit "no", in particular being permanently stored in the configuration.

I think an automatic opt-out should leave the permanent optOut setting undefined.
@gibson042 gibson042 mentioned this issue Mar 14, 2016
Closed
@sindresorhus
Copy link
Member

Agreed. PR welcome :)

gibson042 added a commit to gibson042/insight that referenced this issue Mar 25, 2016
@gibson042
Don't persist timeout-based opt-out
017ea6a 
Fixes yeomangh-39
@gibson042 gibson042 mentioned this issue Mar 25, 2016
Open
gibson042 added a commit to gibson042/insight that referenced this issue Dec 5, 2016
@gibson042
Don't persist timeout-based opt-out
195c954 
Fixes yeomangh-39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @gibson042