Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal #1

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Proposal #1

wants to merge 8 commits into from

Conversation

victoriavilasb
Copy link

Some adicional details as .env treatment, test descriptions and so on.

Copy link
Member

@portellaa portellaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice some, a few changes

.gitignore Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
.env-sample Outdated Show resolved Hide resolved
@rafaelcpalmeida rafaelcpalmeida self-requested a review September 25, 2020 14:38
@portellaa portellaa self-requested a review October 1, 2020 13:52
Copy link
Member

@portellaa portellaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants