-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pinion generate throws error: pcbdraw returned non-zero exit status #27
Comments
This is a problem in PcbDraw; it seems to not be able to handle a curve coming from the board. Could you share the board so I can reproduce the issue? |
Thanks for your response. With your comment I investigated the issue and started to remove items from the board. It seems to me, that vias lead to the issue. If the via diameter is less than or equal to 0.8 pinion generate fails. (I always ran pinion template before.) Please find two kicad_pcb files in a zip below : Minimal_ok let pinion generate pass, whereas Minimal_Error let it fail. The difference is the via dia of 0.8 and 0.9. Hope it helps. If not, I could also provide the complete board |
In the meantime I edit all vias in my board and ran pinion template and pinion generate without luck.
Here is the original board as zip file. |
Ihave the same exact problem and it is seems not to be a pcbdraw issue because i can generate images with pcbdraw from the same pcb without error. I solved reading this post, i had to set all the vias diameter to 1,2mm and via holes to 1,00mm. Another problem i had is that every pin need oval pad shape and NOT circular. and f.paste and b.paste deselected. I had to modify every pin in my project and now it works. See the pictures |
I just tested your board and it works fine for me. Could you give me output of the following commands?
|
Thanks for testing and tracking. Here you are. marius@Amd8Core:/mnt/c/Users/Marius$ pip show pinion
marius@Amd8Core:/mnt/c/Users/Marius$ pip show pcbdraw
marius@Amd8Core:/mnt/c/Users/Marius$ pip show svgpathtools
|
Could you try installing an older version of svgpathtools (via |
This is indeed caused by a regression in |
That solves the issue of "not generating", thanks. Could you tell me, what it means, when it does not find any of the components? Kicad PCB editor and the 3D viewer do display everything as expected (some 3D parts are removed). pinion generate --pack -b ./ATMega4809_Breakout.kicad_pcb -s ./diagram.yaml ./publish
pinion serve -b --directory ./publish/ shows a "blank" board. Only when marking, something is "visible": |
The situation with ImageMagick being constantly broken made me rewrite the conversion handling in PcbDraw. You can install the upstream version of PcbDraw and then, it should work just fine. |
I installed the upstream version by pip install git+https://github.com/yaqwsx/PcbDraw@master . So, pip show pcbdraw gives
The hash seems to be the lastest commit from today morning. Please also find the installed imagemagick version: apt show imagemagick
Then I tried the simpler test: pcbdraw ATMega4809_breakout.kicad_pcb output.svg and it fails with all these warnings. Could it be an issue, that the board-file is made under windows and the kicad in WSL is not able to correctly process the correct paths? However, I tried to replace the paths and env.variables linking to certain libraries. I also tried to export all used footprints into a single (local) library, unfortunately without success. Let me know, if I can check/test/do anything else to investigate the issue. |
Which warnings? Could you show them to me? The change in PcbDraw is such that it no longer uses the unreliable ImageMagick, but instead, it uses either Inkscape or rsvg-convert (at least one of them has to be installed). |
I have installed inkscape now (sudo apt install inkscape) and installed rsvg-convert (sudo apt install librsvg2-bin) and get for
|
My bad; I haven't pushed all the changes. Please update both, PcbDraw and Pinion to upstream version and give it a try. |
Sorry ... I installed the latest upstreams, ran the command and got warnings. Please find the versions below, I checked the hashs and they are the same as shown on github. pcbdraw ATMega4809_Breakout.kicad_pcb output.svg
pip show pinion
pip show drawpcb
|
The warning only says that there are some components that cannot be drawn. But is the board properly rendered on the generated page? If not, could you share the source files and generated directory by Pinion? |
did you find the solution for the not found components? I'm facing the same issue with standard components from the standard 3d library @Optoneer |
Pinion & Pcbdraw are undergoing large changes. The currently released version uses hand-drawn components, and you need to supply them. There is no linkage to the 3D models in KiCAD. The default library is available at https://github.com/yaqwsx/PcbDraw-Lib, however, it is not complete and at the moment, doesn't have all the changes that were introduced with KiCAD 6. In the upcoming release (and already implemented in upstream, already visible in the upstream documentation), Pinion will support working on boards rendered via KiCAD preview. However, this option won't be available on Windows due to the technical limitations of KiCAD. |
that's awesome @yaqwsx, thank you for the feedback! does the won't be available on Windows includes the WSL2 approach? :) if I got it right the KiCad rendering preview will use the same library the 3D render of Pcbnew defines and that's great. |
It will work on WSL and Docker on Windows. It just cannot do it when run natively. Unfortunately, it seems that KiCAD 7 will still miss the essential API parts that would allow us to run it natively and work faster. |
I consider this resolved. We still need to work on the component library, but that is matter of PcbDraw, not Pinion. |
Hi,
I have Ubuntu 20.04 through WSL on my Windows 10 Pro, pip installed Pinion, installed Kicad 6, installed imagemagick. (in that order, if that is important)
Running the template command worked fine (then). When running the generate command, I encountered an issue I cannot resolve myself:
Is it an issue, that it does not find the libraries? I made the board under Windows, but would like to try out your tool.
What can I do?
Cheers, Marius
edt: When generated the template, I did not apply any changes to that. I don't know if that is important.
The text was updated successfully, but these errors were encountered: