Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standby lag polling #115

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

melanholy
Copy link

Not entirely sure about the way I handled requests to lagging standbys . May need a little more thought.

@melanholy melanholy requested a review from x4m February 4, 2020 19:15
@x4m
Copy link
Collaborator

x4m commented Feb 19, 2020

Hi! This seems like an extremely valuable feature! Thanks!
I'm hesitating between mergaing as is and doing few API adjustements.
We need the feauture to be working on primary too. And, probably, it will work just fine if lag polling will return 0 lag.

@g0djan
Copy link
Contributor

g0djan commented Apr 3, 2020

Hi, you have a huge list of files with conflicts due to PR with formatting.
Steps for rebasing.

save files that were changed in your PR
git checkout master
git pull
git checkout
git rebase -i HEAD~0 --onto master(this line delete all your changes, don't forget to save it)
copy back saved files to the repository
format files: find ./ -type f ( -iname *.c -o -iname *.h -o -iname *.cpp -o -iname *.hpp ) -exec clang-format -style=file -i {} ;
git commit -am "Name of PR"
git push -f
If you have a questions or want my help you can ask me here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants