Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix yajra#882 - Due to conflict previous changes were reverted, synchronized repo. #888

Open
wants to merge 2 commits into
base: 10.x
Choose a base branch
from
Open

fix yajra#882 - Due to conflict previous changes were reverted, synchronized repo. #888

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1676751
fix #882
Sudheert7 Sep 5, 2024
3597bf4
Update Sequence.php
Sudheert7 Sep 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Oci8/Schema/Sequence.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ public function nextValue($name)

$name = $this->wrap($name);

return $this->connection->selectOne("SELECT $name.NEXTVAL as \"id\" FROM DUAL")->id;
return $this->connection->selectOne("SELECT '$name.NEXTVAL' as \"id\" FROM DUAL")->id;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The single quote here is unnecessary and it will produce a bad SQL syntax.

}

/**
Expand Down