Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent missed ban behaviour & ABBA Bans #90

Open
clxxiii opened this issue Jun 7, 2022 · 1 comment
Open

Consistent missed ban behaviour & ABBA Bans #90

clxxiii opened this issue Jun 7, 2022 · 1 comment
Assignees
Labels
bug Something isn't working priority 1 Issues that severely impact usage

Comments

@clxxiii
Copy link
Collaborator

clxxiii commented Jun 7, 2022

Take a 2 ban match for example:
If Team A has banned once, and it's Team B's turn to pick, if the timer runs out, Team A will get two bans, and Team B will get one ban,

If Team A hasn't been banned, and their timer runs out, priority will switch to Team B, and both teams will get two bans

The expected behavior is that both cases are the same, whether the ban is skipped, or you lose priority

@clxxiii clxxiii added the bug Something isn't working label Jun 7, 2022
@clxxiii clxxiii self-assigned this Jun 7, 2022
@clxxiii clxxiii changed the title Add "empty ban" Add "empty ban" to teams who miss the ban timer Jun 7, 2022
@clxxiii clxxiii added this to the Closed Beta milestone Jun 7, 2022
@clxxiii clxxiii changed the title Add "empty ban" to teams who miss the ban timer Consistent missed ban behaviour Jun 17, 2022
@clxxiii clxxiii removed this from the Closed Beta milestone Oct 5, 2023
@clxxiii clxxiii added the priority 1 Issues that severely impact usage label May 29, 2024
@clxxiii clxxiii changed the title Consistent missed ban behaviour Consistent missed ban behaviour & ABBA Bans May 29, 2024
@clxxiii
Copy link
Collaborator Author

clxxiii commented May 29, 2024

To add consistency, bans should be implemented in a "queue" style system, where if you miss your timer, it gets appended to the end of the queue.
image

Using an architecture like this should also make implementing an ABBA, ABAB, or AABB ban pattern possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority 1 Issues that severely impact usage
Projects
None yet
Development

No branches or pull requests

1 participant