Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build workflows; fix macos build errors/warnings; update code formatting #5

Merged
merged 9 commits into from
Jul 31, 2023
Merged

Add build workflows; fix macos build errors/warnings; update code formatting #5

merged 9 commits into from
Jul 31, 2023

Conversation

davidlion
Copy link
Member

@davidlion davidlion commented Jul 28, 2023 •
edited
Loading

References

This PR addresses macos build issues that impact y-scope/clp#131.

Description

This PR addresses a few house keeping issues:

Building

  • create github workflows to build on ubuntu-latest and macos-latest
  • address minor macos build issues

Formatting

  • updates clang format and tidy configurations
  • applies clang format to all files
  • reflows comments to be 80 characters

Validation performed

All CLP unittests passing using y-scope/clp#131.

@davidlion davidlion requested a review from SharafMohamed July 28, 2023 00:29
@davidlion davidlion changed the title Workflows Add build workflows; fix macos build errors/warnings; update code formatting Jul 28, 2023
@SharafMohamed SharafMohamed merged commit 066ecc1 into y-scope:main Jul 31, 2023
@davidlion davidlion deleted the workflows branch July 31, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirkrodrigues kirkrodrigues kirkrodrigues approved these changes

@SharafMohamed SharafMohamed SharafMohamed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidlion @SharafMohamed @kirkrodrigues