From 859ce77e980d7ab693b7523c0506637de7aaf500 Mon Sep 17 00:00:00 2001 From: Kirk Rodrigues <2454684+kirkrodrigues@users.noreply.github.com> Date: Tue, 5 Dec 2023 22:47:47 -0500 Subject: [PATCH 1/3] Add pull_request GH workflow trigger to all workflows. --- .github/workflows/clp-core-build-macos.yaml | 10 ++++++++++ .github/workflows/clp-core-build.yaml | 6 ++++++ .github/workflows/clp-execution-image-build.yaml | 5 +++++ 3 files changed, 21 insertions(+) diff --git a/.github/workflows/clp-core-build-macos.yaml b/.github/workflows/clp-core-build-macos.yaml index e7f9f57b6..0e7deec76 100644 --- a/.github/workflows/clp-core-build-macos.yaml +++ b/.github/workflows/clp-core-build-macos.yaml @@ -1,6 +1,16 @@ name: "clp-core-build-macos" on: + pull_request: + paths: + - ".github/workflows/clp-core-build-macos.yaml" + - "components/core/cmake/**" + - "components/core/CMakeLists.txt" + - "components/core/src/**" + - "components/core/tests/**" + - "components/core/tools/scripts/lib_install/macos-12/**" + - "components/core/tools/scripts/deps-download/**" + - "components/core/tools/scripts/utils/build-and-run-unit-tests.sh" push: paths: - ".github/workflows/clp-core-build-macos.yaml" diff --git a/.github/workflows/clp-core-build.yaml b/.github/workflows/clp-core-build.yaml index 01a369558..6787dd47b 100644 --- a/.github/workflows/clp-core-build.yaml +++ b/.github/workflows/clp-core-build.yaml @@ -1,6 +1,12 @@ name: clp-core-build on: + pull_request: + paths: + - ".github/actions/**" + - ".github/workflows/clp-core-build.yaml" + - "components/core/**" + - "!components/core/tools/scripts/lib_install/macos-12/**" push: paths: - ".github/actions/**" diff --git a/.github/workflows/clp-execution-image-build.yaml b/.github/workflows/clp-execution-image-build.yaml index 44b7f6c1e..6a0228c05 100644 --- a/.github/workflows/clp-execution-image-build.yaml +++ b/.github/workflows/clp-execution-image-build.yaml @@ -1,6 +1,11 @@ name: "clp-execution-image-build" on: + pull_request: + paths: + - ".github/workflows/clp-execution-image-build.yaml" + - "components/core/tools/scripts/lib_install/*" + - "tools/docker-images/clp-execution-base-focal/**" push: paths: - ".github/workflows/clp-execution-image-build.yaml" From 9d3918d16f9fc35049a4d85ddfdebff0ba8099bc Mon Sep 17 00:00:00 2001 From: Kirk Rodrigues <2454684+kirkrodrigues@users.noreply.github.com> Date: Tue, 5 Dec 2023 23:17:28 -0500 Subject: [PATCH 2/3] Deduplicate paths watched in workflow. --- .github/workflows/clp-core-build-macos.yaml | 12 ++---------- .github/workflows/clp-core-build.yaml | 8 ++------ .github/workflows/clp-execution-image-build.yaml | 7 ++----- 3 files changed, 6 insertions(+), 21 deletions(-) diff --git a/.github/workflows/clp-core-build-macos.yaml b/.github/workflows/clp-core-build-macos.yaml index 0e7deec76..0a27146f0 100644 --- a/.github/workflows/clp-core-build-macos.yaml +++ b/.github/workflows/clp-core-build-macos.yaml @@ -2,7 +2,7 @@ name: "clp-core-build-macos" on: pull_request: - paths: + paths: &watched_paths - ".github/workflows/clp-core-build-macos.yaml" - "components/core/cmake/**" - "components/core/CMakeLists.txt" @@ -12,15 +12,7 @@ on: - "components/core/tools/scripts/deps-download/**" - "components/core/tools/scripts/utils/build-and-run-unit-tests.sh" push: - paths: - - ".github/workflows/clp-core-build-macos.yaml" - - "components/core/cmake/**" - - "components/core/CMakeLists.txt" - - "components/core/src/**" - - "components/core/tests/**" - - "components/core/tools/scripts/lib_install/macos-12/**" - - "components/core/tools/scripts/deps-download/**" - - "components/core/tools/scripts/utils/build-and-run-unit-tests.sh" + paths: *watched_paths workflow_dispatch: concurrency: diff --git a/.github/workflows/clp-core-build.yaml b/.github/workflows/clp-core-build.yaml index 6787dd47b..f236fa8b2 100644 --- a/.github/workflows/clp-core-build.yaml +++ b/.github/workflows/clp-core-build.yaml @@ -2,17 +2,13 @@ name: clp-core-build on: pull_request: - paths: + paths: &watched_paths - ".github/actions/**" - ".github/workflows/clp-core-build.yaml" - "components/core/**" - "!components/core/tools/scripts/lib_install/macos-12/**" push: - paths: - - ".github/actions/**" - - ".github/workflows/clp-core-build.yaml" - - "components/core/**" - - "!components/core/tools/scripts/lib_install/macos-12/**" + paths: *watched_paths workflow_dispatch: env: diff --git a/.github/workflows/clp-execution-image-build.yaml b/.github/workflows/clp-execution-image-build.yaml index 6a0228c05..4a61374f9 100644 --- a/.github/workflows/clp-execution-image-build.yaml +++ b/.github/workflows/clp-execution-image-build.yaml @@ -2,15 +2,12 @@ name: "clp-execution-image-build" on: pull_request: - paths: + paths: &watched_paths - ".github/workflows/clp-execution-image-build.yaml" - "components/core/tools/scripts/lib_install/*" - "tools/docker-images/clp-execution-base-focal/**" push: - paths: - - ".github/workflows/clp-execution-image-build.yaml" - - "components/core/tools/scripts/lib_install/*" - - "tools/docker-images/clp-execution-base-focal/**" + paths: *watched_paths workflow_dispatch: env: From a414c5637f28f6c86d8f721928d0a06c83f8108f Mon Sep 17 00:00:00 2001 From: Kirk Rodrigues <2454684+kirkrodrigues@users.noreply.github.com> Date: Tue, 5 Dec 2023 23:19:22 -0500 Subject: [PATCH 3/3] Revert "Deduplicate paths watched in workflow." This reverts commit 9d3918d16f9fc35049a4d85ddfdebff0ba8099bc. --- .github/workflows/clp-core-build-macos.yaml | 12 ++++++++++-- .github/workflows/clp-core-build.yaml | 8 ++++++-- .github/workflows/clp-execution-image-build.yaml | 7 +++++-- 3 files changed, 21 insertions(+), 6 deletions(-) diff --git a/.github/workflows/clp-core-build-macos.yaml b/.github/workflows/clp-core-build-macos.yaml index 0a27146f0..0e7deec76 100644 --- a/.github/workflows/clp-core-build-macos.yaml +++ b/.github/workflows/clp-core-build-macos.yaml @@ -2,7 +2,7 @@ name: "clp-core-build-macos" on: pull_request: - paths: &watched_paths + paths: - ".github/workflows/clp-core-build-macos.yaml" - "components/core/cmake/**" - "components/core/CMakeLists.txt" @@ -12,7 +12,15 @@ on: - "components/core/tools/scripts/deps-download/**" - "components/core/tools/scripts/utils/build-and-run-unit-tests.sh" push: - paths: *watched_paths + paths: + - ".github/workflows/clp-core-build-macos.yaml" + - "components/core/cmake/**" + - "components/core/CMakeLists.txt" + - "components/core/src/**" + - "components/core/tests/**" + - "components/core/tools/scripts/lib_install/macos-12/**" + - "components/core/tools/scripts/deps-download/**" + - "components/core/tools/scripts/utils/build-and-run-unit-tests.sh" workflow_dispatch: concurrency: diff --git a/.github/workflows/clp-core-build.yaml b/.github/workflows/clp-core-build.yaml index f236fa8b2..6787dd47b 100644 --- a/.github/workflows/clp-core-build.yaml +++ b/.github/workflows/clp-core-build.yaml @@ -2,13 +2,17 @@ name: clp-core-build on: pull_request: - paths: &watched_paths + paths: - ".github/actions/**" - ".github/workflows/clp-core-build.yaml" - "components/core/**" - "!components/core/tools/scripts/lib_install/macos-12/**" push: - paths: *watched_paths + paths: + - ".github/actions/**" + - ".github/workflows/clp-core-build.yaml" + - "components/core/**" + - "!components/core/tools/scripts/lib_install/macos-12/**" workflow_dispatch: env: diff --git a/.github/workflows/clp-execution-image-build.yaml b/.github/workflows/clp-execution-image-build.yaml index 4a61374f9..6a0228c05 100644 --- a/.github/workflows/clp-execution-image-build.yaml +++ b/.github/workflows/clp-execution-image-build.yaml @@ -2,12 +2,15 @@ name: "clp-execution-image-build" on: pull_request: - paths: &watched_paths + paths: - ".github/workflows/clp-execution-image-build.yaml" - "components/core/tools/scripts/lib_install/*" - "tools/docker-images/clp-execution-base-focal/**" push: - paths: *watched_paths + paths: + - ".github/workflows/clp-execution-image-build.yaml" + - "components/core/tools/scripts/lib_install/*" + - "tools/docker-images/clp-execution-base-focal/**" workflow_dispatch: env: