From 87d52a8ec09915f612331d75057a68e6f79c6494 Mon Sep 17 00:00:00 2001 From: LinZhihao-723 Date: Wed, 29 Nov 2023 10:34:57 -0500 Subject: [PATCH] Code review --- pyproject.toml | 2 ++ src/GSL | 1 - src/clp_ffi_py/ir/native/PyDecoderBuffer.cpp | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) delete mode 160000 src/GSL diff --git a/pyproject.toml b/pyproject.toml index 6854df2c..96e50b42 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -37,11 +37,13 @@ color = true preview = true [tool.cibuildwheel] +# Use `musllinux_1_2` to support C++20 compilation musllinux-aarch64-image = "musllinux_1_2" musllinux-i686-image = "musllinux_1_2" musllinux-ppc64le-image = "musllinux_1_2" musllinux-s390x-image = "musllinux_1_2" musllinux-x86_64-image = "musllinux_1_2" + skip = "pp*" test-command = [ diff --git a/src/GSL b/src/GSL deleted file mode 160000 index 4300304e..00000000 --- a/src/GSL +++ /dev/null @@ -1 +0,0 @@ -Subproject commit 4300304ef24c247b3db0255763f46b9f95c3a83d diff --git a/src/clp_ffi_py/ir/native/PyDecoderBuffer.cpp b/src/clp_ffi_py/ir/native/PyDecoderBuffer.cpp index e2819a61..6116913b 100644 --- a/src/clp_ffi_py/ir/native/PyDecoderBuffer.cpp +++ b/src/clp_ffi_py/ir/native/PyDecoderBuffer.cpp @@ -242,7 +242,7 @@ auto PyDecoderBuffer::populate_read_buffer(Py_ssize_t& num_bytes_read) -> bool { PyErr_NoMemory(); return false; } - auto new_read_buffer{std::span(new_buf, new_capacity)}; + std::span new_read_buffer{new_buf, static_cast(new_capacity)}; std::copy( unconsumed_bytes_in_curr_read_buffer.begin(), unconsumed_bytes_in_curr_read_buffer.end(),