Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct enum property names to PascalCase #39

Open
coderabbitai bot opened this issue Dec 2, 2024 · 1 comment
Open

Correct enum property names to PascalCase #39

coderabbitai bot opened this issue Dec 2, 2024 · 1 comment
Assignees
@junhaoliao

Comments

@coderabbitai
Copy link

coderabbitai bot commented Dec 2, 2024

As discussed in PR #35 and this comment, the enum property names in src/clp_ffi_js/constants.hpp should be updated to PascalCase to adhere to coding conventions.

Requested by @junhaoliao.
@davemarco davemarco mentioned this issue Dec 14, 2024
Merged
@davemarco
Copy link
Contributor

Also per this comment make the enum "LENGTH" more descriptive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junhaoliao junhaoliao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@junhaoliao @davemarco