Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce maxDelay, introduce more defensive coding practices #129

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

mehigh
Copy link
Member

@mehigh mehigh commented Jul 15, 2024

Fixes the bug of not delivering the INP debug data if some of the attribution data was missing.

Tasks

  • Introduced defensive coding practices for all attribution optional data
  • Exposed the maxDelay information if one of the 3 contributors exceed 50ms (inputDelay, processingDelay, presentationDelay), to allow observing high-level patterns

@mehigh mehigh merged commit c1f8765 into master Jul 28, 2024
1 check passed
@mehigh mehigh deleted the fix/inp branch July 28, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant