Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discovery] Investigate List Block Options #496

Closed
jauyong opened this issue Jan 14, 2021 · 11 comments
Closed

[Discovery] Investigate List Block Options #496

jauyong opened this issue Jan 14, 2021 · 11 comments
Assignees

Comments

@jauyong
Copy link

jauyong commented Jan 14, 2021

Feature description

This is to inform #465

List Child / Individual Settings
image
image
image


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  1. Investigate how global vs child settings were handled for the list block

Implementation brief

QA testing instructions

Demo

Changelog entry

@jwold
Copy link

jwold commented Jan 15, 2021

IMG_0265

@jauyong I've been thinking about this card, and did some exploration into how it works versus the List Block. I've proposed a number of changes, which will greatly simplify how users engage with it. The biggest change though is to remove the ability to change settings on individual cards. Changes made affect all cards.

This feels like the right direction, but we should discuss as a team.

@jauyong jauyong self-assigned this Jan 25, 2021
@jwold
Copy link

jwold commented Feb 1, 2021

@jauyong did I put these notes on the wrong block?

@jauyong
Copy link
Author

jauyong commented Feb 4, 2021

@jwold sorry for the huge delay. Now that accessibility stuff has been taken care of I can put focus on this. Are you able to walk the team through these proposed changes? We don't have a scheduled grooming this week, but I'll start to coordinate whenever that is and see what works for you and the team.

@jauyong
Copy link
Author

jauyong commented Feb 12, 2021

@dawidmlynarz to continue reviewing Joshua's mocks and also to consider #465 while looking at this ticket

@dawidmlynarz
Copy link

@jauyong I had a look at the Block settings and I did a little bit of juggling and options grouping. I've listed all the changes below and on the screenshot notes.

Joshua already marked some settings that could potentially work as Global styles and there is a place designed for them in #463.

• Prominent information saying that anything you change here will have a local impact on the block and a link to global settings.
• Separated style options with layout/card settings options to better differentiate these two categories. Later on, we can add color modification here and anything related to styling.
• Columns and Gutter were grouped into one section called 'Cards layout' (tbd) and have a responsive switcher that applies to all options in this group to simplify the amount of interactions.

Block settings

These options apply to the Block since we agreed that styling a single card does not make much sense.

Looking forward to your feedback!

@dawidmlynarz
Copy link

@jauyong I have updated the design above with additional settings that are available on the block level.

Screenshot 2021-02-26 at 08 56 15

There is a potential to redesign the way the user picks the 'Number of Cards'. We can use the same logic as in the Gallery block where you can manage a number of cards dynamically in the WYSIWYG editor. To be discussed with the team.

@jauyong
Copy link
Author

jauyong commented Feb 26, 2021

@dawidmlynarz to update:

  1. Move "number of cards" outside of the "cards layout" section with the device specific settings.
  2. Change slider on number of cards field to something similar to the block inserter

@dawidmlynarz
Copy link

@jauyong I have created a concept of how to incorporate the ability to add cards into the editor. I see two potential ways for the call to action:

Version 1 – Card-sized placeholder with a call to action to add new card
Version 2 – Horizontal bar always below the cards, similiar to how it works in Gallery Block.

Screenshot 2021-03-09 at 09 06 36

Screenshot 2021-03-09 at 09 06 43

Let me know if you have any further feedback.

@jauyong
Copy link
Author

jauyong commented Mar 12, 2021

@dawidmlynarz to add updated mock here to inform #495 and then I'll close this and we'll work on #495

@dawidmlynarz
Copy link

@jauyong Updated mocks are visible below showing scrolled views of the sidebar properties panel.

#496 - Card Collection
#496 - Card Collection - Sidebar scrolled

@jauyong
Copy link
Author

jauyong commented Mar 16, 2021

adding the above to #465 and closing this

@jauyong jauyong closed this as completed Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants