Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-21774: Admin section: make the panel wizard section pass webstandard tests #2796

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Jan 16, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-21774

Changes

Description

  • Replaced inline styling with regular style for the panel wizard tooltip
  • Removed the comment from the test for the panel wizard

Clarifications

  • The inline styling was unecessary, and could easily be replaced with some default styling. This default styling is overrode. Note that later on, inline styling is still added with javascript, but the main objective of this PR is to pass the test.

Executed Tests

  • Successfully passed mvn clean install -f xwiki-platform-distribution/xwiki-platform-distribution-flavor/xwiki-platform-distribution-flavor-test/xwiki-platform-distribution-flavor-test-webstandards -Dxwiki.test.startXWiki=false
  • With manual test, I made sure that the functionnality still works. The tooltip still appears and disappears without any unexpected behavior.

Expected merging strategy

  • Prefers squash: Yes
  • Only on master.

…ndard tests

* Replaced inline styling with regular style for the panel wizard tooltip
* Removed the comment from the test for the panel wizard
@surli surli merged commit 8211065 into xwiki:master Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants