XWIKI-19150: The Page Like UI is not following the common template style for a page

[Sereza7]

Jira URL

https://jira.xwiki.org/browse/XWIKI-19150

Changes

Description

• Added a proper content header to the liker page.
• Added an anchor in the title
• Updated the id of the livetable to avoid a collision with an item in the #tmMoreActions menu

Screenshots & Video

Before PR vvv

After PR vvv

Executed Tests

Succcessfully built with mvn clean install -f xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-api

Expected merging strategy

• Prefers squash: Yes
• Backport to 15.10.X : localized changes on the content of a template, low risk of breaking something.

[manuelleduc]

Also, note that I'm working on https://jira.xwiki.org/browse/XWIKI-18992 which is also going to impact likers.vm.

[manuelleduc]

To be tested but escaping html properties is probably safer.

Suggested change

	#set($titleToDisplay = $services.localization.render('like.likers.title', ["<a href='$doc.getURL()'>$escapetool.xml($doc.plainTitle)</a>"]))
	#set($titleToDisplay = $services.localization.render('like.likers.title', ["<a href='$escapetool.xml($doc.getURL())'>$escapetool.xml($doc.plainTitle)</a>"]))

[Sereza7]

I'm pretty sure we shouldn't escape this URL: https://github.com/search?q=repo%3Axwiki%2Fxwiki-platform+%2Fhref%3D%27.*getURL%2F&type=code

Most of those are not escaped ...

[surli]

@Sereza7 you have conflicts to fix on this one.

[Sereza7]

It was indeed a conflict with changes related to https://jira.xwiki.org/browse/XWIKI-18992 👍
I replaced the updated title with a call to the contentheader.vm template like it's done in other page templates (and what was done on this PR beforehand) :)

The updated Live Data id is the same as the one I changed on the live table, no need to update this.

[github-actions]

The backport to stable-15.10.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-stable-15.10.x stable-15.10.x
# Navigate to the new working tree
cd .worktrees/backport-stable-15.10.x
# Create a new branch
git switch --create backport-2788-to-stable-15.10.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ba4473ad848435053bedbab5d269d3176e893c50
# Push it to GitHub
git push --set-upstream origin backport-2788-to-stable-15.10.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-stable-15.10.x

Then, create a pull request where the base branch is stable-15.10.x and the compare/head branch is backport-2788-to-stable-15.10.x.