Skip to content

Commit

Permalink
XWIKI-19150: The Page Like UI is not following the common template st…
Browse files Browse the repository at this point in the history
…yle for a page (#2788)

* Added a proper content header to the liker page.
* Added an anchor in the title
* Updated teh id of the livetable to avoid a collision with an item in the `#tmMoreActions` menu
* Added a comment to give an indication on the change of livetable id.
* Added back the comment (forgot it on merge conflict fix)
  • Loading branch information
Sereza7 authored Feb 29, 2024
1 parent 54932a8 commit ba4473a
Showing 1 changed file with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@
#livetable_filterObfuscated($map)
$jsontool.serialize($map)
#else
<h1>$escapetool.xml($services.localization.render('like.likers.title', [$doc.plainTitle]))</h1>
#set($titleToDisplay = $services.localization.render('like.likers.title', ["<a href='$doc.getURL()'>$escapetool.xml($doc.plainTitle)</a>"]))
#template('contentheader.vm')
## We rely on the same column name than the Users administration, so we use same translation prefix for now.
#set ($sourceParameters = {
'template': 'likers.vm',
Expand All @@ -108,6 +109,8 @@
'$doc': $doc.documentReference,
'translationPrefix' : 'xe.admin.users.'
})
## The id of the live data needs to be complex in order to avoid 'id collision' that would break
## the liveData.
$services.liveData.render({
'id': 'likersTable',
'properties': 'name,first_name,last_name',
Expand Down

0 comments on commit ba4473a

Please sign in to comment.