Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong residual values #6

Open
JTGRC-public opened this issue Oct 15, 2024 · 0 comments
Open

wrong residual values #6

JTGRC-public opened this issue Oct 15, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@JTGRC-public
Copy link

JTGRC-public commented Oct 15, 2024

I tried the following

  • copy over "load_normalize_clean.csv" to "src"
  • manually created an empty subfolder "load" within "src\case14"
  • for a new virtual env, I have to use older version of libraries (numpy==1.26.4 and matplotlib==3.5.2)
  • at line 204 of "visulization.py", changed "Image.ANTIALIAS" to "Image.LANCZOS" because the former is no longer supported.

After all of these, both "test_operation.ipynb" and "visualization.py" can be run without error.

However, the residual calculated from both "test_operation.ipynb" and "visualization.py" are extremely large. For example, in the testing notebook, the output for the second block of code is

No Measurement: 122 (122,) (122, 122) 1755199.5243315855 119.87093929856714

and the output for the last block is

1755149.2286295495 119.87093929856714

It will be much better for the author to provide a "requirements.txt" file with specific version number for each required python library used in this repo, and also provide the specific python version if necessary. I cannot reproduce the results at the moment, thanks.

@xuwkk xuwkk added documentation Improvements or additions to documentation help wanted Extra attention is needed labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants