Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OOS 11.0.0.2 updated. #3

Open
u-nel opened this issue Apr 19, 2021 · 7 comments
Open

OOS 11.0.0.2 updated. #3

u-nel opened this issue Apr 19, 2021 · 7 comments

Comments

@u-nel
Copy link

u-nel commented Apr 19, 2021

Hmm, The app still works but It doesn't automatically scans my face but I need to manually click the Face icon. This is my only problem for the recent update.

@xubowenhaoren
Copy link
Owner

xubowenhaoren commented Apr 19, 2021

Interesting. Unfortunately, I don't have an OnePlus device with me right now, so I won't be able to fix this shortly.

With that said, I suspect the reason is that in Oxygen OS 11, OnePlus (probably) changed when the face scan kicks in. In Android 10, the face scan kicks in as soon as the screen is on. This is how OPLiftToWake enables lift-to-wake - by only turning on the screen as it detects a lift. But I suppose now it only kicks in after the user presses the power button or clicking the "Face" icon.

@u-nel
Copy link
Author

u-nel commented Apr 22, 2021

I see. Indeed, the pressing of the power button sort of trigger the face scanning immediately.

I gues, I have to wait for the time being.

Thanks for the response.

@xubowenhaoren
Copy link
Owner

In the meantime, I suggest you trying the 2 alternatives to fix the lightUpScreen() method.

  1. Drop-in code replacement: Change the SCREEN_DIM_WAKE_LOCK here to FULL_WAKE_LOCK.
  2. Rewrite the lightUpScreen() method to use the rootless wakeUp() method instead of the current PowerManager approach. This takes more time to fine-tune but is indeed more promising because the rootless wakeUp() simulates pressing the power button.

@u-nel
Copy link
Author

u-nel commented May 3, 2021

I'll give it a try

@michael1900
Copy link

In the meantime, I suggest you trying the 2 alternatives to fix the lightUpScreen() method.

  1. Drop-in code replacement: Change the SCREEN_DIM_WAKE_LOCK here to FULL_WAKE_LOCK.
  2. Rewrite the lightUpScreen() method to use the rootless wakeUp() method instead of the current PowerManager approach. This takes more time to fine-tune but is indeed more promising because the rootless wakeUp() simulates pressing the power button.

Any news about this? Can you release this mod to fix the face unlock "problem"? Thanks

@michael1900
Copy link

I'll give it a try

Hi, any news about this?

@michael1900
Copy link

UP @xubowenhaoren

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants