Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate unnecessary nesting #2

Open
rewong03 opened this issue Jun 26, 2019 · 1 comment
Open

Eliminate unnecessary nesting #2

rewong03 opened this issue Jun 26, 2019 · 1 comment
Assignees
@tskluzac
Labels
bug Something isn't working

Comments

@rewong03
Copy link
Contributor

Lots of nested loops in extract_columnar_metadata. See if it's 1. inefficient 2. necessary.
@tskluzac
Copy link
Contributor

tskluzac commented Jul 1, 2019

Explored in #10. I don't think the nesting is unnecessary, but probably worth seeing what comes up when we benchmark later.

@tskluzac tskluzac added the bug Something isn't working label Jul 1, 2019
@tskluzac tskluzac self-assigned this Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tskluzac tskluzac

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tskluzac @rewong03