Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binary search recursion error for preamble #17

Open
rewong03 opened this issue Jul 24, 2019 · 1 comment
Open

Fix binary search recursion error for preamble #17

rewong03 opened this issue Jul 24, 2019 · 1 comment
Assignees

Comments

@rewong03
Copy link
Contributor

pub8\CdiacBundles\06AQ/06AQ20150818.tsv
pub8\CdiacBundles\33RO

@tskluzac
Copy link
Contributor

[DO NOT CLOSE] I've put a bandaid on it, but it's not entirely fixed.

The issue is that something is allowing both the upper and lower bounds to fall beneath the current row (and converge to the same row). The bandaid is -- if upper-bound and lower-bound are both within 1 of the current_row, then return.

Not robust -- need to investigate the actual source of the problem.

@tskluzac tskluzac self-assigned this Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants