Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JOSS Review: Rename variable in tutorial #214

Open
Midnighter opened this issue Aug 7, 2022 · 0 comments
Open

JOSS Review: Rename variable in tutorial #214

Midnighter opened this issue Aug 7, 2022 · 0 comments

Comments

@Midnighter
Copy link

The lines in the tutorials

from ophyd.sim import hw

hw = hw()

replaces the imported symbol with a local variable. I would consider this bad practice since you can no longer generate a second instance from hw(). Please consider renaming the variable to something other than hw.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Midnighter