Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLUGIN: http get to extern uri #1988

Closed
lblabr opened this issue Nov 10, 2019 · 2 comments
Closed

PLUGIN: http get to extern uri #1988

lblabr opened this issue Nov 10, 2019 · 2 comments
Labels

Comments

@lblabr
Copy link
Contributor

lblabr commented Nov 10, 2019

i would like to implement an url request inside a plugin. how this could be achived ?
just a hint would be great

  • is there already an object wich can be used, if not wich is preferred ?
  • any style guide ?

thanks in advance

Lars

@mcspr
Copy link
Collaborator

mcspr commented Nov 11, 2019

See https://github.com/esp8266/Arduino/tree/master/libraries/ESP8266HTTPClient/examples ?
Note that default timeouts for request failure are pretty generous, I'd look into reducing them for any real use.

I had done another weird client in the #1909 using the ESPAsyncTCP, but that is WIP and I need to get back to that with proper header handling and easier API

@mcspr
Copy link
Collaborator

mcspr commented Nov 23, 2019

Btw, also see my comment in the #1968
Plugin code still uses brokerSubscribe and generic callback, those were replaced with SensorBroker (callback-per-event, see broker.h).

@mcspr mcspr closed this as completed Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants