Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfluxDB doesn't build with latest Core #1565

Closed
mcspr opened this issue Feb 22, 2019 · 3 comments
Closed

InfluxDB doesn't build with latest Core #1565

mcspr opened this issue Feb 22, 2019 · 3 comments
Labels
Arduino Core 2.5.0 Breaking changes in the newest Core version bug influxdb staged for release
Milestone

Comments

@mcspr
Copy link
Collaborator

mcspr commented Feb 22, 2019

Client class happened to change between versions, ESPAsyncTCP's SyncClient is no longer compatible

Source: https://travis-ci.org/mcspr/espurna/jobs/496826731#L537

Building firmware images...
* espurna-1.13.4-dev-travis02.bin --- espurna/pwm.c: In function 'pwm_start':
espurna/pwm.c:394:13: warning: 'RTC_REG_WRITE' macro is deprecated [enabled by default]
RTC_REG_WRITE(FRC1_LOAD_ADDRESS, 0);
^
/home/travis/build/mcspr/espurna/code/espurna/influxdb.ino:15:12: error: cannot declare variable '_idb_client' to be of abstract type 'SyncClient'
SyncClient _idb_client;
^
In file included from /home/travis/build/mcspr/espurna/code/espurna/influxdb.ino:12:0:
.piolibdeps/ESPAsyncTCP/src/SyncClient.h:30:7: note:   because the following virtual functions are pure within 'SyncClient':
class SyncClient: public Client {
^
In file included from /home/travis/.platformio/packages/framework-arduinoespressif8266/libraries/ESP8266WiFi/src/WiFiClient.h:27:0,
from /home/travis/.platformio/packages/framework-arduinoespressif8266/libraries/ESP8266WiFi/src/ESP8266WiFi.h:39,
from .piolibdeps/ESP Async WebServer/src/ESPAsyncWebServer.h:35,
from espurna/config/prototypes.h:167,
from espurna/config/all.h:35,
from /home/travis/build/mcspr/espurna/code/espurna/espurna.ino:22:
/home/travis/.platformio/packages/framework-arduinoespressif8266/cores/esp8266/Client.h:29:21: note: 	virtual int Client::connect(IPAddress&, uint16_t)
virtual int connect(CONST IPAddress& ip, uint16_t port) =0;
^
/home/travis/.platformio/packages/framework-arduinoespressif8266/cores/esp8266/Client.h:37:22: note: 	virtual bool Client::flush(unsigned int)
virtual bool flush(unsigned int maxWaitMs = 0) = 0;
^
/home/travis/.platformio/packages/framework-arduinoespressif8266/cores/esp8266/Client.h:38:22: note: 	virtual bool Client::stop(unsigned int)
virtual bool stop(unsigned int maxWaitMs = 0) = 0;
^
*** [.pioenvs/travis02/src/espurna.ino.cpp.o] Error 1
========================== [ERROR] Took 5.96 seconds ==========================
@mcspr mcspr added bug influxdb Arduino Core 2.5.0 Breaking changes in the newest Core version labels Feb 22, 2019
@xoseperez xoseperez added this to the 1.13.6 milestone Mar 29, 2019
@xoseperez
Copy link
Owner

This is related to me-no-dev/ESPAsyncTCP#109.
Added a wrapper class in the meantime.

xoseperez added a commit that referenced this issue Mar 29, 2019
@mcspr
Copy link
Collaborator Author

mcspr commented Mar 30, 2019

One interesting option is to use https://github.com/boblemaire/asyncHTTPrequest , but the library API needs some changing (one obvious case - double String copy instead of using pointers when using ::send())

@mcspr
Copy link
Collaborator Author

mcspr commented Sep 30, 2019

Also note that upstream has this fixed proper: me-no-dev/ESPAsyncTCP@75c2513
Small fix required to have it working with ASYNC_TCP_SSL_ENABLED (should probably PR that)
#1909 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arduino Core 2.5.0 Breaking changes in the newest Core version bug influxdb staged for release
Projects
None yet
Development

No branches or pull requests

2 participants