Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Hide original countdown" setting makes original timer flicker #41

Open
ladybunne opened this issue Sep 11, 2022 · 6 comments
Open

"Hide original countdown" setting makes original timer flicker #41

ladybunne opened this issue Sep 11, 2022 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@ladybunne
Copy link

Hey there, thanks for your work on the plugin!

I've noticed that even with the "hide original countdown" setting enabled, the original timer appears for what feels like a single frame, making it flicker onto the screen. It's kind of annoying/distracting, and seems unintended.

I can get footage if needed, but it should be pretty straightforward to repro.

@xorus
Copy link
Owner

xorus commented Sep 11, 2022

I do not have this issue :/.
The way it works is that you hides the original element the first frame it can. I couldn't find a way to prevent the game from making it appear in the first place.
Does this issue appeared recently of did it always do it ?
What is your frame rate, do you have vsync on ?

@ladybunne
Copy link
Author

I've only noticed it recently, but it's very likely it's always happened and I only picked up on it as of late.

I run at 60fps with vsync on.

@xorus
Copy link
Owner

xorus commented Sep 11, 2022

Then I just don't know what to do :|.
I'll try to optimize what I can so it doesn't happen but it's a very weird issue.


If anyone else experiences this issue, please let me know.

@xorus xorus added the help wanted Extra attention is needed label Jan 13, 2023
@Cloud7050
Copy link

I noticed a flicker when first trying out this setting, at the 5 second mark. Maybe it only happens once per restart?

@xorus
Copy link
Owner

xorus commented Nov 8, 2023

@Cloud7050 could you send me your config file ? It should be EngageTimer.json inside the salamis config directory. I'm currently on mobile, let me know if you need help to find it

@Cloud7050
Copy link

I'll see if I notice the flicker again in subsequent days' restarts. And see if I can record it. That could give a clearer picture.

My config is nothing special, as I only started trying this plugin today. It's freshly configured. I did enable hiding original countdown.

xorus added a commit that referenced this issue Nov 19, 2023
xorus added a commit that referenced this issue Jan 2, 2024
xorus added a commit that referenced this issue Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants