Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resetDatabase fails to run client-side for projects with audit-argument-checks package added #19

Open
francis-lookback opened this issue Nov 26, 2017 · 1 comment

Comments

@francis-lookback
Copy link

Since the resetDatabase method call doesn't check the options argument, it fails to run when audit-argument-checks is enabled, with the following error:

Exception while invoking method 'xolvio:cleaner/resetDatabase' Error: Did not check() all arguments during call to 'xolvio:cleaner/resetDatabase'

A simple fix to this would be to check the options argument with:
check(options, Match.Optional(Object)).

@francis-lookback
Copy link
Author

francis-lookback commented Nov 26, 2017

Ah, turns out it's not really very useful calling resetDatabase from the client anyway, since the insertion would happen asynchronously anyway, making it unable to happen in a beforeEach. Looks like https://atmospherejs.com/hwillson/stub-collections is the way to go on the client.

So this issue is not so important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant