Toggle fullscreen feature #394
Comments
|
the whole point of contrib is that it's easy to PR to! So if you already have the code, there is no harm in simply doing the PR, and seeing what happens! |
|
Ok I created the PR #395 |
liskin
added a commit
to liskin/xmonad-contrib
that referenced
this issue
Oct 23, 2022
Fairly straightforward, just add two hooks for (un)fullscreening. There are multiple motivations for this: * Users are calling for unfullscreened windows to revert back to their original location if they were floating. * XMonad.Layout.Fullscreen uses some deprecated exports from XMonad.Hooks.EwmhDesktops and reimplements fullscreenEventHook. This commit only adds the hooks. Neither of the motivations are dealt with yet, so the docs are a bit terse still. Related: xmonad#456 Related: xmonad#394 Related: xmonad#626
3 tasks
liskin
added a commit
to liskin/xmonad-contrib
that referenced
this issue
Mar 25, 2023
Fairly straightforward, just add two hooks for (un)fullscreening. There are multiple motivations for this: * Users are calling for unfullscreened windows to revert back to their original location if they were floating. * XMonad.Layout.Fullscreen uses some deprecated exports from XMonad.Hooks.EwmhDesktops and reimplements fullscreenEventHook. This commit only adds the hooks. Neither of the motivations are dealt with yet, so the docs are a bit terse still. Related: xmonad#456 Related: xmonad#394 Related: xmonad#626
liskin
added a commit
to liskin/xmonad-contrib
that referenced
this issue
Mar 25, 2023
Fixes: xmonad#456 Related: xmonad#394 Related: xmonad#626
liskin
added a commit
to liskin/xmonad-contrib
that referenced
this issue
Mar 26, 2023
Fairly straightforward, just add two hooks for (un)fullscreening. There are multiple motivations for this: * Users are calling for unfullscreened windows to revert back to their original location if they were floating. * XMonad.Layout.Fullscreen uses some deprecated exports from XMonad.Hooks.EwmhDesktops and reimplements fullscreenEventHook. This commit only adds the hooks. Neither of the motivations are dealt with yet, so the docs are a bit terse still. Related: xmonad#456 Related: xmonad#394 Related: xmonad#626
liskin
added a commit
to liskin/xmonad-contrib
that referenced
this issue
Mar 26, 2023
Fixes: xmonad#456 Related: xmonad#394 Related: xmonad#626
liskin
added a commit
to liskin/xmonad-contrib
that referenced
this issue
Apr 1, 2023
Fairly straightforward, just add two hooks for (un)fullscreening. There are multiple motivations for this: * Users are calling for unfullscreened windows to revert back to their original location if they were floating. * XMonad.Layout.Fullscreen uses some deprecated exports from XMonad.Hooks.EwmhDesktops and reimplements fullscreenEventHook. This commit only adds the hooks. Neither of the motivations are dealt with yet, so the docs are a bit terse still. Related: xmonad#456 Related: xmonad#394 Related: xmonad#626
liskin
added a commit
to liskin/xmonad-contrib
that referenced
this issue
Apr 1, 2023
Fixes: xmonad#456 Related: xmonad#394 Related: xmonad#626
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I use XMonad.Layout.Fullscreen for fullscreen support and the AddFullscreen and RemoveFullscreen messages to manually make windows fullscreen but there is no easy way (at least I can't see one) to toggle the fullscreen state of a window say with a keybinding. So I went ahead and built my own xmonad-contrib where I added a ToggleFullscreen message and it works. I thought this feature should be in the official xmonad-contrib but I wanted to discuss this first before making a PR.
Sorry if I do something the the wrong way I am new to contributing to open source projects.
The text was updated successfully, but these errors were encountered: