Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate webhook endpoints #121

Open
joe94 opened this issue Sep 17, 2019 · 0 comments
Open

Deprecate webhook endpoints #121

joe94 opened this issue Sep 17, 2019 · 0 comments
Labels
enhancement road-to-argus Issues to be solved for the switch to argus

Comments

@joe94
Copy link
Member

joe94 commented Sep 17, 2019

Once Scytale starts owning XMiDT's webhook registry, suggested steps to deprecate the webhook endpoints include:

Phase 1

Have a flag for Tr1d1um to either (1) serve the request or (2) simply redirecting it to Scytale.

Handling request: In this mode, Tr1d1um will create a new request (must pay close attention to capability check configurations between Scytale and Tr1d1um) to Scytale and then return the response to the caller. Callers should notice no difference from the current behavior in this mode.
Redirection: Perform an HTTP redirect to the scytale endpoint. This would require Tr1d1um users to setup their services and credentials to follow redirects and ultimately update the endpoint they use for webhooks

Phase 2

Drop support for the flag and only support redirection.

Phase 3

Drop support of endpoints.

@joe94 joe94 self-assigned this May 11, 2020
@joe94 joe94 changed the title Delegate webhooks logic to scytale Deprecate webhook endpoints May 13, 2020
@joe94 joe94 added the road-to-argus Issues to be solved for the switch to argus label May 20, 2020
@joe94 joe94 removed their assignment Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement road-to-argus Issues to be solved for the switch to argus
Projects
None yet
Development

No branches or pull requests

1 participant