Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Bearer Token propogation in Scytale #391

Open
chaitanyasingla-dt opened this issue Jul 22, 2024 · 3 comments
Open

Issue with Bearer Token propogation in Scytale #391

chaitanyasingla-dt opened this issue Jul 22, 2024 · 3 comments

Comments

@chaitanyasingla-dt
Copy link

When a bearer token is used to call tr1d1um APIs, the token is successfully propagated to scytale. However, scytale does not further propagate the bearer token to Talaria.

cc: @Sachin4403 @schmidtw

@Sachin4403
Copy link
Contributor

Scytale is using always basic auth(pre-configured in configuration) to communicate with Talaria and here is the code for the same.

scytale/primaryHandler.go

Lines 377 to 381 in c8233d4

if len(cfg.Authorization) > 0 {
options = append(
options,
fanout.WithClientBefore(
gokithttp.SetRequestHeader("Authorization", "Basic "+cfg.Authorization),

Since Scytale APIs are being called from Tr1d1um and Scytale can accept the Basic and Bearer auth so we Scytale must use the same authorisation type while sending request to downstream which was initially accepted by scytale.

@denopink
Copy link
Contributor

denopink commented Jul 23, 2024

Hello 🙂

Talaria should only be accessed by internal servers like scytale so basic auth would suffice.
Also, we don't want to propagate the token to talaria from scytale because talaria would need its own set of permissions.

@schmidtw
Copy link
Member

While that was the case, we would like to support JWTs going from Scytale to Talaria. That improves the security position because the JWT can be rotated more easily and has better controls than basic auth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants