-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bash completions #384
Add bash completions #384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I've missed this a few times. I only ever wrote one completion script but I forgot almost everything about it.
Free desktop Gitlab is down atm. |
fc984bd
to
9e98701
Compare
Great work as always. For the meson hookup you can check out systemd's implementation for reference. |
Add missing `--help` and `--short` entries.
9e98701
to
adebb5a
Compare
Added meson install entry and reworked the commit messages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thanks. A few style nitpicks but that's about it, feel free to merge when those are addressed (or not :)
eb8f500
to
6b38024
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
- Add bash completion script. It parses the commands help messages to provide the completions, thus any new subcommand or option will be supported, as long as it has its entry in the help messages. This should result in low maintenancei effort. - Add installation entry in Meson. The path can be configured using the following options: - `enable-bash-completion` to enable the installation; - `bash-completion-path` to control the installation path. It will default to: `share/bash-completion/completions`. TODO: completion for other shells, such as zsh?
e5d8888
to
aa08702
Compare
WIP. This is the first time I write bash completion, be kind!