Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix typos #944

Merged
merged 1 commit into from
Aug 16, 2023
Merged

refactor: fix typos #944

merged 1 commit into from
Aug 16, 2023

Conversation

bostick
Copy link
Contributor

@bostick bostick commented Aug 3, 2023

No description provided.

@bostick
Copy link
Contributor Author

bostick commented Aug 14, 2023

Any interest in typo fixes?

@gotson
Copy link
Collaborator

gotson commented Aug 14, 2023

Any interest in typo fixes?

Yes, but time is scarce to review

@gotson
Copy link
Collaborator

gotson commented Aug 15, 2023

your changes break code formatting, you can fix it by using mvn spotless:apply

Copy link
Collaborator

@gotson gotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bostick
Copy link
Contributor Author

bostick commented Aug 15, 2023

I ran mvn spotless:apply and included the 2 spots where it fixed formatting and did a force push.

@gotson
Copy link
Collaborator

gotson commented Aug 16, 2023

and did a force push.

please refrain from doing so, it makes the review more difficult, because i don't know what is the delta between my last review

@gotson gotson merged commit 8e999fe into xerial:master Aug 16, 2023
24 checks passed
@gotson gotson changed the title Fix typos refactor: fix typos Aug 16, 2023
@gotson
Copy link
Collaborator

gotson commented Aug 16, 2023

@bostick thanks for the PR !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants