Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the use of YumRepository #171

Open
ydirson opened this issue Oct 1, 2024 · 0 comments
Open

Clarify the use of YumRepository #171

ydirson opened this issue Oct 1, 2024 · 0 comments

Comments

@ydirson
Copy link
Contributor

ydirson commented Oct 1, 2024

We're getting into a case where performInstallation.add_repos() gets passed a YumRepository instance in repos.

I guess this happens because Accessor.findRepository will instanciate a YumRepository (since 32d90da) if a transient network issue will cause isRepo() for both UpdateYumRepository and MainYumRepository to fail, and then ac0d438 assumes everything that is not a UpdateYumRepository is a MainYumRepository.

What do you think @alexbrett ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ydirson