Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialects: (memref) standardise naming of memref-related types to MemRef capitalization #3474

Open
alexarice opened this issue Nov 19, 2024 · 2 comments
Open

dialects: (memref) standardise naming of memref-related types to MemRef capitalization #3474

alexarice opened this issue Nov 19, 2024 · 2 comments
Labels
API Related to changes regarding API of constructs good first issue Good for newcomers

Comments

@alexarice
Copy link
Collaborator

In MemRefType the R is capitalised but it is not in UnrankedMemrefType.
@alexarice
Copy link
Collaborator Author

Which one would be preferable, both are used a fair amount?

@superlopuh
Copy link
Member

MLIR uses MemRef, let's go with that?

@superlopuh superlopuh added the API Related to changes regarding API of constructs label Nov 20, 2024
@superlopuh superlopuh added the good first issue Good for newcomers label Dec 16, 2024
@superlopuh superlopuh changed the title Inconsistency in memref naming dialects: (memref) standardise naming of memref-related types in xDSL to MemRef capitalization Dec 16, 2024
@superlopuh superlopuh changed the title dialects: (memref) standardise naming of memref-related types in xDSL to MemRef capitalization dialects: (memref) standardise naming of memref-related types to MemRef capitalization Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Related to changes regarding API of constructs good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@superlopuh @alexarice