util: Remove unused MilliSleep

Cherry-picked from: fae86c3

Additional edits were needed in wallet.cpp and walletdb.cpp

src/test/scheduler_tests.cpp

@@ -5,6 +5,7 @@
 
 #include "random.h"
 #include "scheduler.h"
+#include "utiltime.h"
 
 #include "test/test_bitcoin.h"
 
@@ -27,11 +28,6 @@ static void microTask(CScheduler& s, boost::mutex& mutex, int& counter, int delt
     }
 }
 
-static void MicroSleep(uint64_t n)
-{
-    boost::this_thread::sleep_for(boost::chrono::microseconds(n));
-}
-
 BOOST_AUTO_TEST_CASE(manythreads)
 {
     // Stress test: hundreds of microsecond-scheduled tasks,
@@ -78,7 +74,7 @@ BOOST_AUTO_TEST_CASE(manythreads)
     for (int i = 0; i < 5; i++)
         microThreads.create_thread(boost::bind(&CScheduler::serviceQueue, &microTasks));
 
-    MicroSleep(600);
+    UninterruptibleSleep(std::chrono::microseconds{600});
     now = boost::chrono::system_clock::now();
 
     // More threads and more tasks:

src/utiltime.cpp

@@ -12,7 +12,6 @@
 
 #include <atomic>
 #include <boost/date_time/posix_time/posix_time.hpp>
-#include <boost/thread.hpp>
 #include <ctime>
 #include <chrono>
 #include <thread>
@@ -93,11 +92,6 @@ int64_t GetLogTimeMicros()
     return GetTimeMicros();
 }
 
-void MilliSleep(int64_t n)
-{
-    boost::this_thread::sleep_for(boost::chrono::milliseconds(n));
-}
-
 std::string DateTimeStrFormat(const char* pszFormat, int64_t nTime)
 {
     static std::locale classic(std::locale::classic());

src/utiltime.h

@@ -34,13 +34,6 @@ int64_t GetTimeMicros();
 /** Returns the system time (not mockable) */
 int64_t GetSystemTimeInSeconds(); // Like GetTime(), but not mockable
 
-/** For testing. Set e.g. with the setmocktime rpc, or -mocktime argument */
-void SetMockTime(int64_t nMockTimeIn);
-/** For testing */
-int64_t GetMockTime();
-
-void MilliSleep(int64_t n);
-
 /**
  * GetTimeMicros() and GetTimeMillis() both return the system time, but in
  * different units. GetTime() returns the system time in seconds, but also
@@ -58,8 +51,6 @@ void SetMockTime(int64_t nMockTimeIn);
 /** For testing */
 int64_t GetMockTime();
 
-void MilliSleep(int64_t n);
-
 /** Return system time (or mocked time, if set) */
 template <typename T>
 T GetTime();

src/wallet/wallet.cpp

@@ -4032,7 +4032,7 @@ bool CWallet::BackupWallet(const std::string& strDest)
                 }
             }
         }
-        MilliSleep(100);
+        UninterruptibleSleep(std::chrono::microseconds{100});
     }
     return false;
 }

src/wallet/walletdb.cpp

@@ -796,7 +796,7 @@ void ThreadFlushWalletDB()
     int64_t nLastWalletUpdate = GetTime();
     while (true)
     {
-        MilliSleep(500);
+        UninterruptibleSleep(std::chrono::microseconds{500});
 
         if (nLastSeen != CWalletDB::GetUpdateCounter())
         {