Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix 15052 NullReferenceException when returning null from DataTemplateSelector #15074

Closed
wants to merge 20 commits into from
Closed

Fix 15052 NullReferenceException when returning null from DataTemplateSelector #15074

wants to merge 20 commits into from

Commits on Jan 17, 2022

  1. Fix NullReferenceExceptions on null from DataTemplateSelector in Tabb… 

    …edPage.ItemTemplate

Not sure what other controls this picks up but it's a start.
    @bakerhillpins
    bakerhillpins committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    7577636 View commit details
    Browse the repository at this point in the history

  2. Add DataTemplateSelector tests for null return value.

    @bakerhillpins
    bakerhillpins committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    daaccec View commit details
    Browse the repository at this point in the history

  3. Fix null reference on DataTemplate recycle storage.

    @bakerhillpins
    bakerhillpins committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    18be4a0 View commit details
    Browse the repository at this point in the history

  4. Validate BindingContext property set with null Template selected.

    @bakerhillpins
    bakerhillpins committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    16c4ea5 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. Fix CollectionView DataTemplateSelector returns null.

    @bakerhillpins
    bakerhillpins committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    4fe81b0 View commit details
    Browse the repository at this point in the history

  2. iOS, ListView with Recycle, handle DataTemplateSelector return null.

    @bakerhillpins
    bakerhillpins committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    2c9325a View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. CollectionView DataTemplateSelector returns null for iOS/Tizen/UAP

    @bakerhillpins
    bakerhillpins committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    8eafd9b View commit details
    Browse the repository at this point in the history

  2. Remove unused DataTemplate code in Flyout. 

    This code is never used because the protected members are never set, thus !null test is never true, and the class has not been specialized. (Cut out and compile with no errors).
    @bakerhillpins
    bakerhillpins committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    8abeb36 View commit details
    Browse the repository at this point in the history

  3. Rename only

    @bakerhillpins
    bakerhillpins committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    a722a99 View commit details
    Browse the repository at this point in the history

  4. Shell support for DataTemplateSelector returns null

    @bakerhillpins
    bakerhillpins committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    bb6937f View commit details
    Browse the repository at this point in the history

  5. Test for null ItemTemplate and shorten null coalescing statement.

    @bakerhillpins
    bakerhillpins committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    686914d View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Move default DataTemplate to single source and update layout to cente… 

    …r label.
    @bakerhillpins
    bakerhillpins committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    295b84d View commit details
    Browse the repository at this point in the history

  2. Use default DataTemplate to create default Page for MultiPage<T> impl… 

    …ementations.
    @bakerhillpins
    bakerhillpins committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    1db1c3e View commit details
    Browse the repository at this point in the history

  3. Handle null from DataTemplateSelectors.

    @bakerhillpins
    bakerhillpins committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    3d72852 View commit details
    Browse the repository at this point in the history

  4. Move default DataTemplate construction into lazy singleton.

    @bakerhillpins
    bakerhillpins committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    92b0cae View commit details
    Browse the repository at this point in the history

  5. Adjust method to always return a DataTemplate.

    @bakerhillpins
    bakerhillpins committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    021ce6b View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2022

  1. Deal with BindableLayout.EmptyViewTemplate selector returning null.

    @bakerhillpins
    bakerhillpins committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    8ebc055 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. Add support for null from Template Selector 

    I've corrected the logic so it can handle a null from a DataTemplateSelector, but I've not corrected the logic that's using the template as a parameter for template selection.
    @bakerhillpins
    bakerhillpins committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    74328da View commit details
    Browse the repository at this point in the history

  2. Add a simple can return null test.

    @bakerhillpins
    bakerhillpins committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    f97dfab View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. Merge remote-tracking branch 'origin/5.0.0' into fix-15052

    @bakerhillpins
    bakerhillpins committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    e6cda2a View commit details
    Browse the repository at this point in the history