Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

fix: Button on ListView should not pass click to listview when disabled #12370

Closed
wants to merge 6 commits into from

Conversation

l4nk4b3l
Copy link

@l4nk4b3l l4nk4b3l commented Oct 5, 2020

Issues Resolved

fixes #8763

Platforms Affected

  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • [] Targets the correct branch
  • [] Tests are passing (or failures are unrelated)

@dnfadmin
Copy link

dnfadmin commented Oct 5, 2020

CLA assistant check
All CLA requirements met.

Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a UITest and a sample case so we can see what this is supposed to fix.

Thanks

Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l4nk4b3l Could you include a sample (and maybe a UITest) where validate the issue and the fix?. Let me know if you need help with something.

@l4nk4b3l
Copy link
Author

l4nk4b3l commented Feb 19, 2021

@l4nk4b3l Could you include a sample (and maybe a UITest) where validate the issue and the fix?. Let me know if you need help with something.

@jsuarezruiz
Is the a guide on how to write a uitest ?
Are there sample tests ?
I don't know where to start.

@jsuarezruiz
Copy link
Contributor

The sample should be added here: https://github.com/xamarin/Xamarin.Forms/tree/5.0.0/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared
About UITest: https://docs.microsoft.com/en-us/appcenter/test-cloud/frameworks/uitest/cheatsheet
Can find many samples in the gallery, but if need anything or you feel blocked let me know and I can create it and share with you.

@l4nk4b3l
Copy link
Author

Thank you!
The additional information was enough so i could add a uitest to proof this issue has been fixed.

@l4nk4b3l
Copy link
Author

l4nk4b3l commented Jul 5, 2022

I would like to know whats going on.
I requested review about 6 months ago.

@thisisthekap
Copy link
Contributor

@jfversluis Any chance that this one is making it into a Xamarin.Forms service release?

@jfversluis
Copy link
Member

Now that we're so close to the sunsetting of Xamarin.Forms unfortunately we won't be able to take this in anymore, we're really sorry about that. Nevertheless, thank you so much for your time and effort that you have put into this PR.

Please have a look at the evolution of Xamarin.Forms, .NET MAUI. A lot of development has been going on there. Hopefully this issue was already fixed in that codebase. If not, feel free to port this over to there.

Again, thank you so much for being a contributor and Xamarin.Forms user!

@jfversluis jfversluis closed this Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] ContextAction Button on ListView Cell on iOS passes Tap to Cell when CanExecute is false
7 participants