-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: Button on ListView should not pass click to listview when disabled #12370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add a UITest and a sample case so we can see what this is supposed to fix.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l4nk4b3l Could you include a sample (and maybe a UITest) where validate the issue and the fix?. Let me know if you need help with something.
@jsuarezruiz |
The sample should be added here: https://github.com/xamarin/Xamarin.Forms/tree/5.0.0/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared |
Thank you! |
I would like to know whats going on. |
@jfversluis Any chance that this one is making it into a Xamarin.Forms service release? |
Now that we're so close to the sunsetting of Xamarin.Forms unfortunately we won't be able to take this in anymore, we're really sorry about that. Nevertheless, thank you so much for your time and effort that you have put into this PR. Please have a look at the evolution of Xamarin.Forms, .NET MAUI. A lot of development has been going on there. Hopefully this issue was already fixed in that codebase. If not, feel free to port this over to there. Again, thank you so much for being a contributor and Xamarin.Forms user! |
Issues Resolved
fixes #8763
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist