Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on Android 12 #245

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Conversation

angpysha
Copy link

@angpysha angpysha commented Sep 24, 2022

This PR fixes issue #236 and it based on the previous PR #237 created by mos379.

@angpysha angpysha closed this Sep 24, 2022
@angpysha angpysha reopened this Sep 24, 2022
@mos379
Copy link

mos379 commented Sep 24, 2022

would be great if anyone from the original project team could work on this...

@angpysha
Copy link
Author

angpysha commented Sep 24, 2022

would be great if anyone from the original project team could work on this...

Hope, yes. Looks like the problem is in internal yamls. I have not access to Azure DevOps build logs.
You can use now my custom feed https://www.myget.org/F/xam-tests/api/v3/index.json

@mos379
Copy link

mos379 commented Sep 24, 2022

would be great if anyone from the original project team could work on this...

Hope, yes. Looks like the problem is in internal yamls. You can use now my custom feed https://www.myget.org/F/xam-tests/api/v3/index.json

Thanks, problem is that I'm relying on this to be corrected, so that
https://github.com/CrossGeeks/FacebookClientPlugin
can upgrade their reference and make the plugin working with android12 again...

@AnTo0o0o
Copy link

AnTo0o0o commented Dec 1, 2022

Guys, I can't upgrade my app because of this :(
Will a new version be released anytime soon?

@thisisthekap
Copy link
Contributor

@AnTo0o0o I created a slim binding for the facebook android sdk to fix the issue for my usecase: https://github.com/thisisthekap/Xamarin.FacebookSlim.Droid

Feel free to contribute to this repository in case you need additional features exposed through the slim binding.

@dev-xam
Copy link

dev-xam commented Dec 20, 2022

Pull request #245 have errors while compiling
global.json:

 "sdk": {
    "version": "6.0.300",

Every project in .csproj has:
<Project Sdk="MSBuild.Sdk.Extras/2.0.54">

Those versions are not compatible with each other. You need to change sdk version to 6.0.100, then download necessary SDK from dotnet microsoft website, and then finally build cake will run without errors. Alternatively you can update version of MSBuild.Sdk in all projects.

@weksil weksil mentioned this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants