Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address iframe resizing issue in jupyter notebooks #124

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

dakshpokar
Copy link
Collaborator

@dakshpokar dakshpokar commented Oct 17, 2024

Description

This PR includes changes for removing overflow on iframes and resizing them according to content of the plot.

Type of Change

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Pull Request

Description

This PR enhances iframe resizing behavior to dynamically adjust height and width based on content size and user interaction. Specifically, the height is recalculated with additional space (100px) when the braille-input field is focused, and 50px otherwise. This ensures the iframe is not clipped during braille mode. The script also adds event listeners for focusin, focusout, and resize events to trigger appropriate resizing as needed, which were added by @krishnanand5.

@dakshpokar dakshpokar marked this pull request as ready for review October 17, 2024 21:30
Copy link
Collaborator

@krishnanand5 krishnanand5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dakshpokar,

The changes are fine on Shiny. Thank you for taking care of the dynamic height adjustment when braille is active. Let me know if we can address my comments.

Regards,
Krishna Anandan Ganesan.

Copy link
Member

@jooyoungseo jooyoungseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jooyoungseo jooyoungseo merged commit b437831 into xability:main Oct 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants