Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoLogin with some issues #78

Open
baszero opened this issue May 23, 2016 · 0 comments
Open

AutoLogin with some issues #78

baszero opened this issue May 23, 2016 · 0 comments

Comments

@baszero
Copy link
Contributor

baszero commented May 23, 2016

What do you think about the following improvements that should be made in the AutoLogin.java?

Source: https://github.com/wyona/yanel/blob/master/src/webapp/src/java/org/wyona/yanel/servlet/security/impl/AutoLogin.java

Improvements:

  • The current implementation forces a renewal every 30 minutes. The values should be retrieved via protected getters so that every realm can subclass the current AutoLogin on overwrite these getters in order to implement another renewal period
  • The current implementation does not support multiple valid cookies for the same domain.
  • The current implementation uses a static final SimpleDateFormat object. According to the javadoc, that implementation is not thread-safe so it should be newly generated for each request.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant