-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Battery Usage #44
Comments
Are you sure you're running the latest version? As battery usage has been significantly improved in the last few betas... It's now hardly noticeable (definitely not as significant as 53%, which I also had in beta 54 or so) Not sure about this one, but hooking that up would mean two apps to achieve the same result, right? Haha, and would kinda defeat the purpose of @KrauseFx's app :P |
Using 1.0 (60) so looks to be the latest at least in my TestFlight app. Was thinking the native code would replace the React Native version if battery usage can't be improved rather than be seperate. Although I know @KrauseFx is using it to check out React Native. |
Mh, that should have been fixed... weird. Yeah, feel free to look into the project and see if you can improve it 👍 Having a less accurate location until WWDC starts sounds very reasonable to me |
Updating iOS to see if that improves things at all. |
Hmm weird! But having less accuracy before wwdc doesn't solve the problem and would mean that everyone at WWDC would have really bad battery life. Which could also mean that they will either turn off background location sharing or even delete the app |
Will see if the iOS update improves things, did see some issues around locationd reported by others in the forums and spotted that a bunch in my devices logs. Changing it to significant location updates would improve it prior to WWDC but not during the conference, likely when battery life is needed most. Will see if I can spot anything, although not used React Native too much. |
Just to update, still seeing battery usage with the latest update to iOS and the app. https://cl.ly/2T0T151B0f2j |
My guess as to why battery drain is high is due to the distance filter being set to An alternative solution could involve adding a geofence once a user's location stops moving for a certain amount of time, and only ramping up GPS once they break out of that geofence. https://github.com/wwdc-family/app/blob/master/app/mapViewComponent.js#L224 |
Sounds good to me @stephensilber 👍 If you have some free time, feel free to submit a PR improving the battery usage 🚀 |
Will try to put something together before the weekend 👍 |
I was playing with this last night. Not sure I'm competent enough with React to get something useful together by this weekend. A simpler fix would be to only user |
In the last 24 hours it's used 53%. Wonder if it might be better to use significant location changes in the run up to WWDC before switching out to more accurate location?
If it helps, my side project for location tracking for another event is native and cook possibly hook it up with the family DB. Although know you're wanting to check out React Native. 👍
The text was updated successfully, but these errors were encountered: