Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive video snippet... #225

Open
adamglenn opened this issue Feb 7, 2017 · 5 comments
Open

Responsive video snippet... #225

adamglenn opened this issue Feb 7, 2017 · 5 comments
Assignees
Labels
feature request mercury editor Related to the Mercury WYSIWYG editor.

Comments

@adamglenn
Copy link

Can we get a snippet that accepts a YouTube URL and outputs the standard Youtube embed iframe (with no height or width) wrapped in a div with class "u-wvu-embed-container"? Also would be cool to have options such as "allowfulscreen" and whatever other standard parameters YouTube allows.

@nreckart
Copy link
Member

nreckart commented Feb 7, 2017

Isn't this already possible? Insert "Media", choose "Video", paste a YouTube URL...

This results in the following output:

<iframe style="width: 774px; height: 353px;" src="//www.youtube.com/embed/JEJbyL5Zaaa?wmode=transparent" allowfullscreen="true" frameborder="0"></iframe>

@adamglenn
Copy link
Author

adamglenn commented Feb 7, 2017

Not that I know of, in order to have the video be responsive the class has to be applied to another div that wraps the iframe and there can be no height or width on the iframe. Unless you know a better way to do responsive videos. The media option applies class to iframe itself and adds a height + width.

@nreckart
Copy link
Member

nreckart commented Feb 7, 2017

Ok, then I'd say the existing mechanism should be modified instead of creating a separate snippet. Having multiple ways to insert a YouTube videos sounds confusing. Consider it on the list.

@nreckart
Copy link
Member

Can someone provide a list of the all the options we want to support for the YouTube embed, such as "allowfulscreen" mentioned above?

@zeroedin
Copy link
Contributor

https://developers.google.com/youtube/player_parameters#Parameters

Assuming you'd want to support all of these. Below are the ones that might be preset or static.

cc_load_policy might just be static as 1 for accessibility.

autoplay should prolly always be 0 but could be made the case for just a preset and overridden.

hl prolly should be preset en but overridable for the campus in dubai?

Opinions?

@nreckart nreckart self-assigned this May 23, 2017
@adamjohnson adamjohnson added mercury editor Related to the Mercury WYSIWYG editor. and removed Q3 delivery labels May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request mercury editor Related to the Mercury WYSIWYG editor.
Projects
None yet
Development

No branches or pull requests

4 participants