Fix #353: Add request validation for new request / response classes #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jandusil
commented
Jul 12, 2023
jandusil
commented
- Init draft commit
- Add simple bean validators
- Init draft commit - Add simple bean validators
petrdvorak
reviewed
Aug 30, 2023
There was a problem hiding this comment.
Not sure why this is required... The classes you modified are actually already validated (see ActivationCodeRequestValidator and PushRegisterRequestValidator) so the change does not add any value.
Looking at the code, we should also add a handler method for validation exceptions as with the current format, we might miss some opportunities for good error handling. ;-)
cc @romanstrobl
|
@petrdvorak Sorry this one is still a draft, the code is very random |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.