Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve authenticator name and display name validation for user defined authenticators #22063

Closed
Thisara-Welmilla opened this issue Dec 18, 2024 · 0 comments

Comments

@Thisara-Welmilla
Copy link
Contributor

Thisara-Welmilla commented Dec 18, 2024

Description

Issue:

Following improvements need to be done to the custom authentication management.

  1. Addressing Naming Conflicts for User-Defined and future System-Defined Authenticators
    Currently, for user-defined authenticators, it is checking for any conflict with system-defined names making authenticator name unique.
    The reqirement is to have unique identifier for the amr values. However, with the implementation so far, if a custom authenticator is created with the name whatsappAuthenticator and we later introduce a system authenticator with the same name, it would result in a conflict. There improve authenticator name regex validation to check whether authenticator name start with custom- prefix with atleast three charactors.
  2. In addtion to above validate authenticator name uniqueness across both local and federared authenticator names.
  3. Improve display name validation to check whether it has atleast three charactors.

Version

No response

@Thisara-Welmilla Thisara-Welmilla self-assigned this Dec 18, 2024
@Thisara-Welmilla Thisara-Welmilla moved this to In Progress in Identity Server 7.1.0 Dec 18, 2024
@Thisara-Welmilla Thisara-Welmilla moved this from In Progress to Todo in Identity Server 7.1.0 Dec 18, 2024
@Thisara-Welmilla Thisara-Welmilla added this to the 7.1.0-alpha milestone Dec 18, 2024
@Thisara-Welmilla Thisara-Welmilla changed the title Addressing Naming Conflicts for User-Defined and future System-Defined Authenticators Improve authenticator name and display name validation for user defined authenticators Jan 16, 2025
@Thisara-Welmilla Thisara-Welmilla moved this from Todo to In Progress in Identity Server 7.1.0 Jan 16, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Identity Server 7.1.0 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant