[5.10.x] Helm deployment pattern 2 #268

darsham3 · 2020-11-10T14:33:32Z

Changes

This PR adds Helm chart deployment pattern 2 for IS 5.10 with Identity Analytics 5.8.

Related Issue - #270

CLAassistant · 2020-11-10T14:33:37Z

All committers have signed the CLA.

dmxunlimit · 2020-11-11T06:42:47Z

advanced/is-pattern-2/requirements.lock

@@ -0,0 +1,6 @@
+dependencies:


@darsham3 is this required file ?

dmxunlimit · 2020-11-11T06:44:10Z

advanced/is-pattern-2/config/is/deployment/server/eventpublishers/1

@@ -0,0 +1,13 @@
+<?xml version='1.0' encoding='UTF-8' standalone='no'?>


@darsham3 is this required ? seems file a duplicate file to sessiondata publisher.

chirangaalwis · 2020-11-13T08:02:33Z

advanced/is-pattern-2/Chart.yaml

@@ -0,0 +1,20 @@
+# Copyright (c) 2018, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.


@darsham3 shall we please update the license header year to latest? Please update the other files if applicable.

updated as 2020 in all relevant files

chirangaalwis · 2020-11-13T08:04:04Z

advanced/is-pattern-2/README.md

+ - Deploy the Kubernetes resources using the Helm Chart
+
+    ```
+    helm install <RELEASE_NAME> <HELM_HOME>/is-pattern-1 --version 5.10.0-2 --namespace <NAMESPACE> --dependency-update


@darsham3 please update the pattern name in the instruction. Please fix similar issues if there are any other.

chirangaalwis · 2020-11-13T08:04:48Z

advanced/is-pattern-2/README.md

+ - Deploy the Kubernetes resources using the Helm Chart
+
+    ```
+    helm install <RELEASE_NAME> <HELM_HOME>/is-pattern-1 --version 5.10.0-2 --namespace <NAMESPACE> --dependency-update


@darsham3 please update the release version to 5.10.0-3 as this will be the next release number. Please fix applicable, similar scenarios.

chirangaalwis · 2020-11-13T08:12:03Z

advanced/is-pattern-2/README.md

+
+The output under the relevant column stands for the following.
+
+- NAME: Metadata name of the Kubernetes Ingress resource (defaults to `wso2is-pattern-1-identity-server-ingress`)


@darsham3 it would be better to add the Dashboard hostname details and instructions associated with it as well. Please sync this with the NOTES.txt output.

advanced/is-pattern-2/config/is-analytics-dashboard/conf/dashboard/deployment.yaml

chirangaalwis · 2020-11-13T08:14:14Z

advanced/is-pattern-2/requirements.yaml

+dependencies:
+  - name: mysql-is
+    version: "5.10.0-2"
+    repository: file://../databases/mysql-is/


@darsham3 please refer to the official repository in the commit instead of the local charts directory file.

chirangaalwis · 2020-11-13T08:16:02Z

advanced/is-pattern-2/templates/_helpers.tpl

+
+{{- define "fullname" -}}
+{{- "wso2is-pattern-2" }}
+{{- end -}}


@darsham3 please add a new EOF line. Please check other files as well. If any, please fix them.

chirangaalwis · 2020-11-13T08:17:04Z

.../is-pattern-2/templates/analytics-worker/identity-server-analytics-worker-1-statefulset.yaml

+        configMap:
+          name: is-analytics-worker-carbon-conf
+      {{ end }}
+


@darsham3 please remove this unnecessary EOF line.

chirangaalwis · 2020-11-13T08:19:31Z

.../is-pattern-2/templates/analytics-worker/identity-server-analytics-worker-2-statefulset.yaml

+  namespace : {{ .Release.Namespace }}
+spec:
+  replicas: {{ default 1 .Values.wso2.deployment.wso2isAnalyticsWorker2.replicas }}
+  # strategy:


@darsham3 please remove this since it is not needed.

chirangaalwis · 2020-11-13T08:20:06Z

advanced/is-pattern-2/templates/analytics-worker/is-analytics-worker-carbon-conf.yaml

+      {{ . }}
+    {{- end }}
+  {{- end }}
+


@darsham3 please remove this unnecessary EOF line.

ThilinaManamgoda · 2020-11-13T08:44:09Z

advanced/is-pattern-2/templates/_helpers.tpl

@@ -0,0 +1,97 @@
+{{/*
+Copyright (c) 2019, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.


License header year should be 2020.

ThilinaManamgoda · 2020-11-13T08:45:45Z

advanced/is-pattern-2/templates/_helpers.tpl

+{{/*
+Expand the name of the chart.
+*/}}
+{{- define "is-pattern-1.name" -}}


Why do we have pattern-1 related values here?

removed unnecessary values.

ThilinaManamgoda · 2020-11-13T08:47:52Z

.../is-pattern-2/templates/analytics-worker/identity-server-analytics-worker-1-statefulset.yaml

+  namespace : {{ .Release.Namespace }}
+spec:
+  replicas: {{ default 1 .Values.wso2.deployment.wso2isAnalyticsWorker1.replicas }}
+  # strategy:


Shall we please remove commented lines if not required.

chirangaalwis · 2020-11-14T05:29:23Z

advanced/is-pattern-2/Chart.yaml

+description: A Helm chart for the deployment of WSO2 Identity And Access Management pattern 2
+name: is-pattern-2
+version: 5.10.0-3
+icon: https://wso2.cachefly.net/wso2/sites/all/images/wso2logo.svg


@darsham3 please add a new EOF line.

chirangaalwis · 2020-11-14T05:30:17Z

advanced/is-pattern-2/README.md

@@ -0,0 +1,285 @@
+# Helm Chart for a clustered deployment of WSO2 Identity Server


@darsham3 I suppose the pattern name has to be ...Identity Server with Analytics Support.

chirangaalwis · 2020-11-14T05:33:22Z

.../is/deployment/server/eventpublishers/IsAnalytics-Publisher-wso2event-AuthenticationData.xml

+    <property name="receiverURL">tcp://wso2is-pattern-2-analytics-worker-1-service:7612|tcp://wso2is-pattern-2-analytics-worker-2-service:7612</property>
+    <property encrypted="false" name="password">admin</property>
+  </to>
+</eventPublisher>


@darsham3 please add a new line at EOF.

advanced/is-pattern-2/requirements.yaml

chirangaalwis · 2020-11-14T05:37:02Z

...pattern-2/templates/analytics-dashboard/identity-server-analytics-dashboard-statefulset.yaml

+  namespace : {{ .Release.Namespace }}
+spec:
+  replicas: {{ default 2 .Values.wso2.deployment.wso2isAnalyticsDashboard.replicas }}
+  # strategy:


@darsham3 let's leave the strategy section without keeping it commented out. No need to maintain commented out configurations.

Plus, we can assume that we are using the default StatefulSet update strategy, Kubernetes RollingUpdates.

advanced/is-pattern-2/templates/is/wso2is-pattern-2-identity-server-conf-event-publisher.yaml

advanced/is-pattern-2/templates/is/wso2is-pattern-2-identity-server-conf-trust-store.yaml

advanced/is-pattern-2/templates/is/wso2is-pattern-2-identity-server-conf.yaml

advanced/is-pattern-2/templates/is/wso2is-pattern-2-identity-server-ingress.yaml

advanced/is-pattern-2/templates/is/wso2is-pattern-2-identity-server-statefulset.yaml

chirangaalwis · 2020-11-17T04:49:49Z

advanced/is-pattern-2/templates/is/wso2is-pattern-2-identity-server-conf-event-publisher.yaml

@@ -0,0 +1,31 @@
+


@darsham3 please remove this extra line.

chirangaalwis · 2020-11-17T04:57:33Z

advanced/is-pattern-2/values.yaml

+      imagePullPolicy: Always
+
+      # Number of deployment replicas
+      replicas: 1


@darsham3 why are we having a single replica by default? We can go ahead with 2 replicas by default.

chirangaalwis · 2020-11-17T05:01:06Z

...ed/is-pattern-2/templates/analytics-worker/identity-server-analytics-worker-statefulset.yaml

+  name: {{ template "fullname" . }}-analytics-worker-statefulset
+  namespace : {{ .Release.Namespace }}
+spec:
+  replicas: {{ default 1 .Values.wso2.deployment.wso2isAnalyticsWorker.replicas }}


@darsham3 no need to define default values at the source level. We can depend on the values provided at the values.yaml file, as the default values.

Please apply the same to other values, where necessary.

chirangaalwis · 2020-11-17T05:04:45Z

...pattern-2/templates/analytics-dashboard/identity-server-analytics-dashboard-statefulset.yaml

@@ -0,0 +1,193 @@
+# Copyright (c) 2020, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.


@darsham3 for the Dashboard the ideal option is to use a Kubernetes Deployment definition. Can we use a Deployment definition in this case?

chirangaalwis · 2020-11-20T04:33:35Z

advanced/is-pattern-2/templates/analytics-worker/identity-server-analytics-worker-service.yaml

+  clusterIP: None
+  selector:
+    deployment: {{ template "fullname" . }}-analytics-worker
+    node: node-1


@darsham3 we don't need this label. Only deployment: {{ template "fullname" . }}-analytics-worker is enough when mapping to the service.

chirangaalwis · 2020-11-20T04:33:55Z

...ed/is-pattern-2/templates/analytics-worker/identity-server-analytics-worker-statefulset.yaml

+        deployment: {{ template "fullname" . }}-analytics-worker
+        app: is-pattern-2
+        monitoring: {{ .Values.wso2.monitoring.prometheus.jmxJobName }}
+        node: node-1


@darsham3 we don't need this label.

chirangaalwis · 2020-11-21T05:24:40Z

@darsham3 appreciate if you can create an issue for this and link in this PR.

Also, in order to get this released please update the README documentation and change log documentation.

darsham3 added 5 commits November 9, 2020 18:28

add pattern 2 deployment for is 5.10

7561e6c

add client-truststore config map

90b8ab9

update README

89b5c6f

fix trust store name

f0d0818

update allocated cpu and memory to IS pod

6096a08

darsham3 added 2 commits November 11, 2020 11:04

tune IS node allocated memory and cpus

d60c7aa

removed unnecessary files

33cdb08

dmxunlimit approved these changes Nov 12, 2020

View reviewed changes

chirangaalwis requested changes Nov 13, 2020

View reviewed changes

chirangaalwis requested review from ThilinaManamgoda and DilanUA November 13, 2020 08:22

ThilinaManamgoda approved these changes Nov 13, 2020

View reviewed changes

darsham3 added 2 commits November 13, 2020 15:45

review comment changes

c1bae8e

review comment changes

d2765d5

chirangaalwis requested changes Nov 14, 2020

View reviewed changes

darsham3 added 3 commits November 15, 2020 13:04

add new lines in EOF

b97b54f

remove duplicate analytic worker node configs

bb25a15

fix IS server analytic worker connctivity issue

2046711

chirangaalwis requested changes Nov 17, 2020

View reviewed changes

darsham3 added 2 commits November 18, 2020 12:35

change the replica of identity server as 2

d1188f2

removed extra new lines

9480aba

chirangaalwis requested changes Nov 20, 2020

View reviewed changes

darsham3 added 2 commits November 20, 2020 11:55

removed unnecessary labels

dc3c541

remove irrelavant labels from service

9d87d6b

chirangaalwis approved these changes Nov 21, 2020

View reviewed changes

chirangaalwis merged commit a6e907e into wso2:5.10.x Nov 21, 2020

darsham3 mentioned this pull request Nov 25, 2020

Helm Resources for WSO2 IAM 5.10.0 - Deployment Pattern 2 #270

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[5.10.x] Helm deployment pattern 2 #268

[5.10.x] Helm deployment pattern 2 #268

darsham3 commented Nov 10, 2020 •

edited

Loading

CLAassistant commented Nov 10, 2020 •

edited

Loading

dmxunlimit Nov 11, 2020

dmxunlimit Nov 11, 2020

chirangaalwis Nov 13, 2020

darsham3 Nov 13, 2020

chirangaalwis Nov 13, 2020

chirangaalwis Nov 13, 2020

chirangaalwis Nov 13, 2020

chirangaalwis Nov 13, 2020

chirangaalwis Nov 13, 2020

chirangaalwis Nov 13, 2020

chirangaalwis Nov 13, 2020

chirangaalwis Nov 13, 2020

ThilinaManamgoda Nov 13, 2020

ThilinaManamgoda Nov 13, 2020

darsham3 Nov 13, 2020

ThilinaManamgoda Nov 13, 2020

chirangaalwis Nov 14, 2020

chirangaalwis Nov 14, 2020

chirangaalwis Nov 14, 2020

chirangaalwis Nov 14, 2020

chirangaalwis Nov 17, 2020

chirangaalwis Nov 17, 2020

chirangaalwis Nov 17, 2020

chirangaalwis Nov 17, 2020

darsham3 Nov 19, 2020

chirangaalwis Nov 20, 2020

chirangaalwis Nov 20, 2020

chirangaalwis commented Nov 21, 2020

		@@ -0,0 +1,13 @@
		<?xml version='1.0' encoding='UTF-8' standalone='no'?>

		@@ -0,0 +1,20 @@
		# Copyright (c) 2018, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.


		The output under the relevant column stands for the following.

		- NAME: Metadata name of the Kubernetes Ingress resource (defaults to `wso2is-pattern-1-identity-server-ingress`)

		@@ -0,0 +1,97 @@
		{{/*
		Copyright (c) 2019, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.

		@@ -0,0 +1,285 @@
		# Helm Chart for a clustered deployment of WSO2 Identity Server

		@@ -0,0 +1,193 @@
		# Copyright (c) 2020, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.

[5.10.x] Helm deployment pattern 2 #268

[5.10.x] Helm deployment pattern 2 #268

Conversation

darsham3 commented Nov 10, 2020 • edited Loading

Changes

CLAassistant commented Nov 10, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chirangaalwis commented Nov 21, 2020

darsham3 commented Nov 10, 2020 •

edited

Loading

CLAassistant commented Nov 10, 2020 •

edited

Loading