[v5.10.x] [mysql] Identity datasource pool options are not generated properly

[chalitha1989]

Description:

According to IS config generation values (repository/resources/conf/default.json), it only populates shared db 's pool params by default but not the identityDb params.

"database.shared_db.id": "SHARED_DB",
"database.shared_db.pool_options.maxActive": "50",
"database.shared_db.pool_options.maxWait": "60000",
"database.shared_db.pool_options.testOnBorrow": "true",
"database.shared_db.pool_options.validationInterval": "30000",
"database.shared_db.pool_options.defaultAutoCommit": "true",
"database.shared_db.jmx_enable": "false",

As a result, the datasource will be configured only with the validation query ('SELECT 1'). We need to fix this in [1]

[1]

kubernetes-is/advanced/is-pattern-1/values.yaml

Line 119 in 8f0b94f

[database.identity_db.pool_options]

Suggested Labels:
5.10.0

Suggested Assignees:
NA

Affected Product Version:
5.10.0

OS, DB, other environment details and versions:
mysql

Steps to reproduce:

Related Issues:
NA

[chirangaalwis]

@omindu shouldn't we address this within the product and add the relevant default values in the default.json (at least from future versions)?

Also, can we depend on the relevant DB pool options and their mapping default values which had been used in past IS versions for version 5.10.0, as well (since, for this product version we may have to explicitly define them in customized deployment.toml file within the installation resources)?

[chirangaalwis]

As per internal discussion with @omindu, it was suggested that this will be fixed at the product level in future releases (see wso2/product-is#9155).

[chirangaalwis]

Moving to Future milestone as this will be handled in the product in future releases.